The argument format hint of -Pf option is ambiguous

Bug #1486855 reported by Yingzhe Zeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
Medium
Yingzhe Zeng

Bug Description

The help output of -Pf option for stack-create/stack-preview/stack-update is as following:

#################################################################
-Pf <KEY=VALUE>, --parameter-file <KEY=VALUE>
                        Parameter values from file used to create the stack.
                        This can be specified multiple times. Parameter value
                        would be the content of the file
#################################################################

The format hint <KEY=VALUE> is kind of misleading, people may think VALUE is an actual value to be set to parameter KEY.
But actually VALUE should be a file path which contains the value to be set.

So perhaps changing this format hint to <KEY=FILE> would be better.

Changed in python-heatclient:
status: New → Triaged
importance: Undecided → Medium
Changed in python-heatclient:
assignee: nobody → Yingzhe Zeng (zengyingzhe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/216515

Changed in python-heatclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/216515
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=91e20bc0721c641e4cd8c2f18d29c2f286e47e6e
Submitter: Jenkins
Branch: master

commit 91e20bc0721c641e4cd8c2f18d29c2f286e47e6e
Author: zengyingzhe <email address hidden>
Date: Tue Aug 25 11:37:46 2015 +0800

    Improve the format hint of -Pf option

    Change the format hint of -Pf option for stack-create/stack-preview
    /stack-update commands, from <KEY=VALUE> to <KEY=FILE>.

    Closes-Bug: #1486855
    Change-Id: Ib6117325d1b582710bd6b9cddfdbc5e9971b3707

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
milestone: none → 0.7.0
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.