Debug curl statement should include globoff for IPv6 URLs

[justinsb]

Curl needs "--globoff" when dealing with Ipv6 URLs.

The debug output should therefore include "--globoff"

echo ${OS_AUTH_URL}
http://[fd00::c10d]:8081/openstack/identity/v2.0

nova --debug list

REQ: curl -i http://[fd00::c10d]:8081/openstack/identity/v2.0/tokens -X POST -H "Content-Type: application/json" -H "Accept: application/json" -H "User-Agent: python-novaclient" -d '{"auth": {"tenantName": "default", "passwordCredentials": {"username": "admin", "password": "secret"}}}'

...

should be:

REQ: curl --globoff -i http://[fd00::c10d]:8081/openstack/identity/v2.0/tokens -X POST -H "Content-Type: application/json" -H "Accept: application/json" -H "User-Agent: python-novaclient" -d '{"auth": {"tenantName": "default", "passwordCredentials": {"username": "admin", "password": "secret"}}}'

I think the logic could be as simple as checking if the string starts with http://[ or https://[

[Abhishek Chanda (abhishek-i)]

This is a known bug in curl (#30 here) http://curl.haxx.se/docs/knownbugs.html
While we can fix novaclient, I think this should be fixed upstream and not us.

[Johannes Erdfelt (johannes.erdfelt)]

This is an awkward kind of bug since it's just a debug statement. novaclient doesn't actually call curl. I guess it was originally done that way for debugging/troubleshooting purposes.

Since novaclient should never need to use globs, it could always print out a curl command line with the -g option.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/134544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/134544
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=e91d469704046db19356fbbe063ba7e541b24e65
Submitter: Jenkins
Branch: master

commit e91d469704046db19356fbbe063ba7e541b24e65
Author: sridhargaddam <email address hidden>
Date: Fri Nov 14 14:26:53 2014 +0000

    Curl statements to include globoff for IPv6 URLs

    Novaclient displays curl statements for debugging/troubleshooting
    purposes. For IPv6 URLs, curl requires --globoff to be passed in
    the arguments. Since novaclient does not use curl directly, this
    patch displays the curl commands with globoff option which works
    for both IPv4 and IPv6 URLs.

    Closes-Bug: #1228744
    Change-Id: Ib7099e8e3bbc15f29bbaa1db37ef21e78a74e7bc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136327

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136329

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136332

[Sridhar Gaddam (sridhargaddam)]

Patch fir Oslo-incubator: https://review.openstack.org/#/c/136698/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136327
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=c859cb71c2236a8aa3a59b9ce07ce8e60d763254
Submitter: Jenkins
Branch: master

commit c859cb71c2236a8aa3a59b9ce07ce8e60d763254
Author: sridhargaddam <email address hidden>
Date: Fri Nov 21 12:58:10 2014 +0000

    Curl statements to include globoff for IPv6 URLs

    python-keystoneclient displays curl statements for debugging/troubleshooting
    purposes. For IPv6 URLs, curl requires --globoff to be passed in the
    arguments. Since keystoneclient does not use curl directly, this patch
    displays the curl commands with globoff option which works for both
    IPv4 and IPv6 URLs.
    Fix adapted from python-novaclient Ib7099e8e3bbc15f29bbaa1db37ef21e78a74e7bc

    Closes-Bug: #1228744
    Change-Id: Ia05e622dea653597d412ffe0987077616fbb18af

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136332
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=0d69f021d961c0458d93bcbecdfbe5e53434cf0c
Submitter: Jenkins
Branch: master

commit 0d69f021d961c0458d93bcbecdfbe5e53434cf0c
Author: sridhargaddam <email address hidden>
Date: Fri Nov 21 13:11:38 2014 +0000

    Curl statements to include globoff for IPv6 URLs

    python-heatclient displays curl statements for debugging/troubleshooting
    purposes. For IPv6 URLs, curl requires --globoff to be passed in the
    arguments. Since heatclient does not use curl directly, this patch
    displays the curl commands with globoff option which works for both
    IPv4 and IPv6 URLs.
    Fix adapted from python-novaclient Ib7099e8e3bbc15f29bbaa1db37ef21e78a74e7bc

    Closes-Bug: #1228744
    Change-Id: I1ace9268b09e6fc0d0c0ff02ce1f2e31940d961d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136329
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=465c5cef8d23dcd5400fdfb1aae6d7155c0d44a6
Submitter: Jenkins
Branch: master

commit 465c5cef8d23dcd5400fdfb1aae6d7155c0d44a6
Author: sridhargaddam <email address hidden>
Date: Fri Nov 21 13:04:29 2014 +0000

    Curl statements to include globoff for IPv6 URLs

    python-glanceclient displays curl statements for debugging/troubleshooting
    purposes. For IPv6 URLs, curl requires --globoff to be passed in the
    arguments. Since glanceclient does not use curl directly, this patch
    displays the curl commands with globoff option which works for both
    IPv4 and IPv6 URLs.
    Fix adapted from python-novaclient Ib7099e8e3bbc15f29bbaa1db37ef21e78a74e7bc

    Closes-Bug: #1228744
    Change-Id: Ie02c4e75ca1ab995102aa55bbff39b2161218b2d