duplicate return status code

Bug #1719476 reported by Jin Li on 2017-09-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gluon
Low
Jin Li

Bug Description

In the gluon/backend proton_client file line 57: https://github.com/openstack/gluon/blob/master/gluon/backends/proton_client.py#L57
when do_post is processing the response, status_code != 201 is checked twice. One of them should be status_code != 200.

Jin Li (jl7351) on 2017-09-25
Changed in python-gluon:
assignee: nobody → Jin Li (jl7351)
importance: Undecided → Low
importance: Low → Medium
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gluon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/507299

Changed in python-gluon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gluon (master)

Reviewed: https://review.openstack.org/507299
Committed: https://git.openstack.org/cgit/openstack/gluon/commit/?id=27f386ab68315abf50d8697bdaea9c564c472f87
Submitter: Jenkins
Branch: master

commit 27f386ab68315abf50d8697bdaea9c564c472f87
Author: JinLi <email address hidden>
Date: Mon Sep 25 15:55:24 2017 -0700

    Change status code to 200

    In do_post, "status_code != 201" is checked for twice, one of them should be "status_code != 200"

    Change-Id: Ia344225f1d5a013183d6af2c7876f4acab401546
    Closes-Bug: #1719476

Changed in python-gluon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gluon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/507921

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gluon (stable/pike)

Reviewed: https://review.openstack.org/507921
Committed: https://git.openstack.org/cgit/openstack/gluon/commit/?id=9f43bfed7d25aaa2f7824a8816a537c0dae228d7
Submitter: Jenkins
Branch: stable/pike

commit 9f43bfed7d25aaa2f7824a8816a537c0dae228d7
Author: JinLi <email address hidden>
Date: Mon Sep 25 15:55:24 2017 -0700

    Change status code to 200

    In do_post, "status_code != 201" is checked for twice, one of them should be "status_code != 200"

    Change-Id: Ia344225f1d5a013183d6af2c7876f4acab401546
    Closes-Bug: #1719476
    (cherry picked from commit 27f386ab68315abf50d8697bdaea9c564c472f87)

tags: added: in-stable-pike
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers