wrong default version

Bug #1661108 reported by Jin Li on 2017-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gluon
Undecided
Jin Li

Bug Description

In gluon/api/root.py line 85, the RootController's get method returns Root.convert(). And in the Root class, line 65 and 66, the convert method uses 'v1' as the default version. But the RootController class sets 'proton' as default version. I leave comment in gerrit for this issue: https://review.openstack.org/#/c/399051/3/gluon/api/root.py

Jin Li (jl7351) on 2017-02-01
Changed in python-gluon:
assignee: nobody → Jin Li (jl7351)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gluon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/429121

Changed in python-gluon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gluon (master)

Reviewed: https://review.openstack.org/429121
Committed: https://git.openstack.org/cgit/openstack/gluon/commit/?id=6316e37eb53512e6a1edab580ba8ed117cd3be69
Submitter: Jenkins
Branch: master

commit 6316e37eb53512e6a1edab580ba8ed117cd3be69
Author: Jin Li <email address hidden>
Date: Fri Feb 3 16:50:11 2017 -0800

    Return the correct verion in RootController's get method

    The RootController's get method returns 'v1' as the default version.
    It should have returned "proton" instead

    Change-Id: I723e5e1486c026aaad58a0c09267740c33e830e9
    Closes-Bug: #1661108

Changed in python-gluon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gluon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/436580

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gluon (stable/ocata)

Reviewed: https://review.openstack.org/436580
Committed: https://git.openstack.org/cgit/openstack/gluon/commit/?id=df4cd31fe5d22db610ddd2f5964513d8cacdfcd0
Submitter: Jenkins
Branch: stable/ocata

commit df4cd31fe5d22db610ddd2f5964513d8cacdfcd0
Author: Jin Li <email address hidden>
Date: Fri Feb 3 16:50:11 2017 -0800

    Back port this bug fix to stable/ocata

    Return the correct verion in RootController's get method

    The RootController's get method returns 'v1' as the default version.
    It should have returned "proton" instead

    Change-Id: I723e5e1486c026aaad58a0c09267740c33e830e9
    Closes-Bug: #1661108
    (cherry picked from commit 6316e37eb53512e6a1edab580ba8ed117cd3be69)

tags: added: in-stable-ocata
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers