Help text not displayed without a running glance server

Bug #1481729 reported by Flavio Percoco
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
High
Flavio Percoco
Kilo
Fix Committed
High
Flavio Percoco

Bug Description

Glanceclient depends on having a running cloud/glance to do anything useful, even providing help. This is not only unfortunate from a user perspective but also an issue for `openstack-doc-tools` since they need to generate docs[0].

Lets make sure we don't depend on the schemas being around to generate the docs.

[0] https://review.openstack.org/#/c/195473/

description: updated
Changed in python-glanceclient:
assignee: nobody → Flavio Percoco (flaper87)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209536

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/209536
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=3949e0e918e2501c4953a7d9beb58511688d84e1
Submitter: Jenkins
Branch: master

commit 3949e0e918e2501c4953a7d9beb58511688d84e1
Author: Flavio Percoco <email address hidden>
Date: Thu Aug 6 00:19:48 2015 +1000

    Ship the default image schema in the client

    Now that we have stable branches for clients, it's easier to keep track
    of the current default image's schema in Glance and update it
    respectively. This patch adds the current image schema, including the
    schema-properties.

    One good reason to do this is to be able to react when a running Glance
    instance is not around to be introspected. It's really unfortunate that
    things like help text can't be rendered when there image schema is not
    available in the system.

    We could keep the schema in a json file but rather than shipping data
    files with glanceclient we can just have it in the python modules.

    Change-Id: I9b8cc1d18d6717ccf991fb8149ab13c06d653ee4
    Closes-bug: #1481729

Changed in python-glanceclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/212038

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/kilo)

Reviewed: https://review.openstack.org/212038
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=e7a801d54aae4a5d9c858888165b431c5854132a
Submitter: Jenkins
Branch: stable/kilo

commit e7a801d54aae4a5d9c858888165b431c5854132a
Author: Flavio Percoco <email address hidden>
Date: Thu Aug 6 00:19:48 2015 +1000

    Ship the default image schema in the client

    Now that we have stable branches for clients, it's easier to keep track
    of the current default image's schema in Glance and update it
    respectively. This patch adds the current image schema, including the
    schema-properties.

    One good reason to do this is to be able to react when a running Glance
    instance is not around to be introspected. It's really unfortunate that
    things like help text can't be rendered when there image schema is not
    available in the system.

    We could keep the schema in a json file but rather than shipping data
    files with glanceclient we can just have it in the python modules.

    Conflicts:
     glanceclient/v2/shell.py

    Change-Id: I9b8cc1d18d6717ccf991fb8149ab13c06d653ee4
    Closes-bug: #1481729
    (cherry picked from commit 3949e0e918e2501c4953a7d9beb58511688d84e1)

Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-glanceclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/269496

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 0.17.3

This issue was fixed in the openstack/python-glanceclient 0.17.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.