Glance Client

Glance copy-image import command fails due to incorrect validation

Bug #2051761 reported by Pranali Deore
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
High
Unassigned
Antelope
Fix Released
High
Unassigned
Bobcat
Fix Released
High
Unassigned

Bug Description

Steps to reproduce:

$ glance image-import 54e86884-fffd-4288-8d52-9087201e3ef3 --store cheap --import-method copy-image

Import method should be 'glance-download' if REMOTE SERVICE INTERFACE is provided.

Import method copy-image fails due to incorrect validation for glance-download.

Abhishek Kekane (abhishek-kekane)
Changed in python-glanceclient:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-glanceclient/+/907290

Changed in python-glanceclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-glanceclient/+/907290
Committed: https://opendev.org/openstack/python-glanceclient/commit/3c5dd2381f4f577411ad1023ad1bd1a280626bb5
Submitter: "Zuul (22348)"
Branch: master

commit 3c5dd2381f4f577411ad1023ad1bd1a280626bb5
Author: Pranali Deore <email address hidden>
Date: Wed Jan 31 06:54:20 2024 +0000

    Remove incorrect validation for glance-download import method

    Since REMOTE SERVICE INTERFACE has default value to 'public',
    it doesn't make sense to have validation for the same.

    Removing this validation and added few missing tests for
    glance-download import method

    Closes-Bug: #2051761
    Change-Id: I89adf23aac5db4f2c46379546def2f71d7c8e163

Changed in python-glanceclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/python-glanceclient/+/907275

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/python-glanceclient/+/907275
Committed: https://opendev.org/openstack/python-glanceclient/commit/d739d313a772bbec9039eef0825e3407b6970808
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit d739d313a772bbec9039eef0825e3407b6970808
Author: Pranali Deore <email address hidden>
Date: Wed Jan 31 06:54:20 2024 +0000

    Remove incorrect validation for glance-download import method

    Since REMOTE SERVICE INTERFACE has default value to 'public',
    it doesn't make sense to have validation for the same.

    Removing this validation and added few missing tests for
    glance-download import method

    Closes-Bug: #2051761
    Change-Id: I89adf23aac5db4f2c46379546def2f71d7c8e163
    (cherry picked from commit 3c5dd2381f4f577411ad1023ad1bd1a280626bb5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 4.5.0

This issue was fixed in the openstack/python-glanceclient 4.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/python-glanceclient/+/912748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/python-glanceclient/+/912748
Committed: https://opendev.org/openstack/python-glanceclient/commit/d94f5633632a9f6be59948474cb97ab5486c9496
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d94f5633632a9f6be59948474cb97ab5486c9496
Author: Pranali Deore <email address hidden>
Date: Wed Jan 31 06:54:20 2024 +0000

    Remove incorrect validation for glance-download import method

    Since REMOTE SERVICE INTERFACE has default value to 'public',
    it doesn't make sense to have validation for the same.

    Removing this validation and added few missing tests for
    glance-download import method

    Conflicts:
         glanceclient/tests/unit/v2/test_shell_v2.py

    NOTE: Resolved conflicts caused due to I1d8c69acd5d61fdc426469cd87d1ace81871e60f

    Closes-Bug: #2051761
    Change-Id: I89adf23aac5db4f2c46379546def2f71d7c8e163
    (cherry picked from commit 3c5dd2381f4f577411ad1023ad1bd1a280626bb5)
    (cherry picked from commit d739d313a772bbec9039eef0825e3407b6970808)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 4.3.1

This issue was fixed in the openstack/python-glanceclient 4.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 4.4.1

This issue was fixed in the openstack/python-glanceclient 4.4.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.