Client doesn't check image status before start uploading the file

[Maxim Sava]

Glance client failed with "Image status transition from active to saving is not allowed" when run tempest test in concurrency

Details in:
----------
1.https://zuul.opendev.org/t/openstack/build/44b780086a844d22a0e258389735c59b/log/controller/logs/screen-g-api.txt

2.https://review.opendev.org/c/openstack/barbican-tempest-plugin/+/897279?tab=change-view-tab-header-zuul-results-summary

Step to reproduce:
-----------------
1.Devstack conf:

USE_CINDER_FOR_GLANCE=True
disable_service n-net
enable_service q-svc
disable_service q-agt
enable_service q-dhcp
disable_service q-l3
enable_service q-meta
enable_plugin barbican https://opendev.org/openstack/barbican
enable_service rabbit mysql key

2.Run tempest test in concurrency with glance and cinder backend.

barbican_tempest_plugin.tests.scenario.test_image_signing.ImageSigningVolumeTest.test_boot_instance_from_volume_with_signed_image

Actual result:
--------------
Image status transition from active to saving is not allowed

Log:

Oct 04 08:58:17.420788 np0035410479 <email address hidden>[92936]: DEBUG glance.domain [None req-3ede92e1-a583-40be-b795-c3dbfed6a376 tempest-ImageSigningVolumeTest-1262391347 tempest-ImageSigningVolumeTest-1262391347-project-member] Image status transition from active to saving is not allowed {{(pid=92936) status /opt/stack/glance/glance/domain/__init__.py:156}}

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data [None req-3ede92e1-a583-40be-b795-c3dbfed6a376 tempest-ImageSigningVolumeTest-1262391347 tempest-ImageSigningVolumeTest-1262391347-project-member] Image status transition from active to saving is not allowed: glance.common.exception.InvalidImageStatusTransition: Image status transition from active to saving is not allowed

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data Traceback (most recent call last):

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data File "/opt/stack/glance/glance/api/v2/image_data.py", line 139, in upload

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data image.status = 'saving'

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data File "/opt/stack/glance/glance/domain/proxy.py", line 23, in set_attr

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data return setattr(getattr(self, target), attr, value)

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data File "/opt/stack/glance/glance/domain/proxy.py", line 23, in set_attr

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data return setattr(getattr(self, target), attr, value)

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data File "/opt/stack/glance/glance/domain/proxy.py", line 23, in set_attr

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data return setattr(getattr(self, target), attr, value)

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data [Previous line repeated 1 more time]

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data File "/opt/stack/glance/glance/domain/__init__.py", line 157, in status

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data raise e

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data glance.common.exception.InvalidImageStatusTransition: Image status transition from active to saving is not allowed

Oct 04 08:58:17.424765 np0035410479 <email address hidden>[92936]: ERROR glance.api.v2.image_data