glanceclient has no support to add type while creating md-property for namespace

[Abhishek Kekane]

python-glanceclient has no support to add type while creating md-property for namespace using md-property-create command.

glance help md-property-create
usage: glance md-property-create --name <NAME> --title <TITLE> --schema
                                 <SCHEMA>
                                 <NAMESPACE>

Create a new metadata definitions property inside a namespace.

Positional arguments:
  <NAMESPACE> Name of namespace the property will belong.

Optional arguments:
  --name <NAME> Internal name of a property.
  --title <TITLE> Property name displayed to the user.
  --schema <SCHEMA> Valid JSON schema of a property.

glance md-property-create OS::Admin::TestingNameSpace --name testing_property --title "Testing Property" --schema {}
'type' is a required property

Failed validating 'required' in schema:
    {'additionalProperties': False,
     'definitions': {'positiveInteger': {'minimum': 0, 'type': 'integer'},
                     'positiveIntegerDefault0': {'allOf': [{'$ref': '#/definitions/positiveInteger'},
                                                           {'default': 0}]},
                     'stringArray': {'items': {'type': 'string'},
                                     'minItems': 1,
                                     'type': 'array',
                                     'uniqueItems': True}},
     'name': 'property',
     'properties': {'additionalItems': {'type': 'boolean'},
                    'default': {},
                    'description': {'type': 'string'},
                    'enum': {'type': 'array'},
                    'items': {'properties': {'enum': {'type': 'array'},
                                             'type': {'enum': ['array',
                                                               'boolean',
                                                               'integer',
                                                               'number',
                                                               'object',
                                                               'string',
                                                               None],
                                                      'type': 'string'}},
                              'type': 'object'},
                    'maxItems': {'$ref': '#/definitions/positiveInteger'},
                    'maxLength': {'$ref': '#/definitions/positiveInteger'},
                    'maximum': {'type': 'number'},
                    'minItems': {'$ref': '#/definitions/positiveIntegerDefault0'},
                    'minLength': {'$ref': '#/definitions/positiveIntegerDefault0'},
                    'minimum': {'type': 'number'},
                    'name': {'maxLength': 80, 'type': 'string'},
                    'operators': {'items': {'type': 'string'},
                                  'type': 'array'},
                    'pattern': {'format': 'regex', 'type': 'string'},
                    'readonly': {'type': 'boolean'},
                    'required': {'$ref': '#/definitions/stringArray'},
                    'title': {'type': 'string'},
                    'type': {'enum': ['array',
                                      'boolean',
                                      'integer',
                                      'number',
                                      'object',
                                      'string',
                                      None],
                             'type': 'string'},
                    'uniqueItems': {'default': False, 'type': 'boolean'}},
     'required': ['type', 'title', 'name']}

On instance:
    {'name': 'testing_property', 'title': 'Testing Property'}

API reference: https://docs.openstack.org/api-ref/image/v2/metadefs-index.html?expanded=create-object-detail,create-property-detail#create-property

[Abhishek Kekane (abhishek-kekane)]

So as I suspect we can use --schema to pass all this information, we need either update the help message in client or else need to add examples in docs about how to create metadefs.

But IMO as it is required option we should make this provision to pass it explicitly and not through the json.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-glanceclient/+/856303

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-glanceclient 4.4.0 release.