Pass boolean instead of string for --all-stores, --allow-failure options

Bug #1871674 reported by Abhishek Kekane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Critical
Unassigned

Bug Description

Newly added command line options --all-stores, --allow-failure are boolean but from python-glanceclient we are passing it as a string to glance API. This will cause problem if those API parameters are not converted to boolean at API side.

Also as per documentation we expect these parameters as boolean in the API as well.

Changed in python-glanceclient:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.opendev.org/718521
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=dff5c881bdbc7f0cf03d88e974ae4234cb646aa1
Submitter: Zuul
Branch: master

commit dff5c881bdbc7f0cf03d88e974ae4234cb646aa1
Author: Abhishek Kekane <email address hidden>
Date: Wed Apr 8 17:11:18 2020 +0000

    Pass --all-stores, --allow-failure as bool to API

    Newly added command line options --all-stores, --allow-failure are boolean
    but we are passing it as a string to glance API. This will cause problem if
    those parameters are not converted to boolean at API side.

    Passing these parameters as boolean instead of string to API.

    Change-Id: I8d4eab9241fc9bb24bc40b47bf18d63c86a97d77
    Closes-Bug: #1871674

Changed in python-glanceclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/718551

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/ussuri)

Reviewed: https://review.opendev.org/718551
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=5a4385073b24d6555de6c5f057e6c499b67eb542
Submitter: Zuul
Branch: stable/ussuri

commit 5a4385073b24d6555de6c5f057e6c499b67eb542
Author: Abhishek Kekane <email address hidden>
Date: Wed Apr 8 17:11:18 2020 +0000

    Pass --all-stores, --allow-failure as bool to API

    Newly added command line options --all-stores, --allow-failure are boolean
    but we are passing it as a string to glance API. This will cause problem if
    those parameters are not converted to boolean at API side.

    Passing these parameters as boolean instead of string to API.

    Change-Id: I8d4eab9241fc9bb24bc40b47bf18d63c86a97d77
    Closes-Bug: #1871674
    (cherry picked from commit dff5c881bdbc7f0cf03d88e974ae4234cb646aa1)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 3.1.1

This issue was fixed in the openstack/python-glanceclient 3.1.1 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers