python-glanceclient block forever with http

[Feng Wen]

In python-glanceclient, the timeout parameter doesn't work (for example: cinder.glance_request_timeout).

This causes cinder/nova to be blocked forever in case of bad network.

In glanceclient/common/http.py, the timeout parameter is only assigned, but it is not passed to the session at the time of the request.

Did I miss something?

[Feng Wen (cnwenf)]

python-glanceclient version: stein

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/651325

[Cyril Roelandt (cyril-roelandt)]

This makes sense,I proposed the above fix so that we can discuss it over a review :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/651325
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=d589aa257d3ab99a50444ff42f43b3b9d650d089
Submitter: Zuul
Branch: master

commit d589aa257d3ab99a50444ff42f43b3b9d650d089
Author: Cyril Roelandt <email address hidden>
Date: Tue Apr 9 18:42:52 2019 +0200

    HTTPClient: actually set a timeout for requests

    The 'timeout' attribute was previously left unused.

    Change-Id: If615c390302425fe5a646b4651ec6f56aa08fd22
    Closes-Bug: #1822052

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-glanceclient 2.17.0 release.