Failing tests when building Rocky Debian package

[Thomas Goirand]

The below unit tests are failing under Debian Sid. It is possible that it's due to OpenSSL 1.1.1 (but this needs further investigation).

======================================================================
FAIL: glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_no_key
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_no_key
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "glanceclient/tests/unit/test_ssl.py", line 198, in test_v2_requests_valid_cert_no_key
    self.fail('No appropriate failure message is received')
  File "/usr/lib/python2.7/dist-packages/unittest2/case.py", line 690, in fail
    raise self.failureException(msg)
AssertionError: No appropriate failure message is received

======================================================================
FAIL: glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification_no_compression
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification_no_compression
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "glanceclient/tests/unit/test_ssl.py", line 145, in test_v2_requests_cert_verification_no_compression
    self.fail('No certificate failure message is received')
  File "/usr/lib/python2.7/dist-packages/unittest2/case.py", line 690, in fail
    raise self.failureException(msg)
AssertionError: No certificate failure message is received

======================================================================
FAIL: glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "glanceclient/tests/unit/test_ssl.py", line 95, in test_v1_requests_cert_verification
    self.fail('No certificate failure message is received')
  File "/usr/lib/python2.7/dist-packages/unittest2/case.py", line 690, in fail
    raise self.failureException(msg)
AssertionError: No certificate failure message is received

======================================================================
FAIL: glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification_no_compression
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification_no_compression
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "glanceclient/tests/unit/test_ssl.py", line 112, in test_v1_requests_cert_verification_no_compression
    self.fail('No certificate failure message is received')
  File "/usr/lib/python2.7/dist-packages/unittest2/case.py", line 690, in fail
    raise self.failureException(msg)
AssertionError: No certificate failure message is received

======================================================================
FAIL: glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "glanceclient/tests/unit/test_ssl.py", line 128, in test_v2_requests_cert_verification
    self.fail('No certificate failure message is received')
  File "/usr/lib/python2.7/dist-packages/unittest2/case.py", line 690, in fail
    raise self.failureException(msg)
AssertionError: No certificate failure message is received

[Cyril Roelandt (cyril-roelandt)]

I can confirm this.

On Debian Sid (OpenSSL 1.1.1-1), the following tests fail:

glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v1_requests_cert_verification_no_compression
glanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_cert_verification_no_compression

On Debian testing (OpenSSL 1.1.0h-4), there are no failures.

In a Docker container, all tests pass on Debian Sid *with OpenSSL from testing*.

In a Docker container, all tests pass on Fedora 29 with openssl-1.1.1-0.pre9.1.fc29.x86_64.

tl;dr: the Debian failure seems related to the 1.1.0->1.1.1 upgrade of OpenSSL, but there are no issues with OpenSSL 1.1.1 on Fedora, so this really needs further investigation.

[Abhishek Kekane (abhishek-kekane)]

Could anyone of you provide the environment details you are using like,
which OS (other than mentioned), which python version these tests are failing?

[Thomas Goirand (thomas-goirand)]

Hi Abhishek Kekane,

As mentioned by Cyril, it's Debian Sid with Python 3.7 and OpenSSL 1.1.1.

Could you please not set the importance to Low? It's quite important to fix ASAP.

FYI Cyril, in Debian, OpenSSL has TLS 1.0 and 1.1 disabled, which is probably why it's failing.

[Cyril Roelandt (cyril-roelandt)]

We no longer support Rocky or Python 2.7, so let's mark this as invalid. Feel free to reopen if this is an issue in a more recent release.