Glance Client

glanceclient uses only md5 for download validation

Bug #1788323 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
High
Brian Rosmaita
Glance Client 2.14.0 "stein-1"
Rocky
Fix Committed
Critical
Brian Rosmaita
Glance Client 2.13.0 "stable-rocky-bugfix"

Bug Description

Now that the Glance "multihash" is available in Rocky, the client should prefer the multihash to the legacy 'checksum' property when validating image data downloads.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/594769

Changed in python-glanceclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/594769
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=8fd7e8c664e82d805dc4a12534b3d7e3fcaac606
Submitter: Zuul
Branch: master

commit 8fd7e8c664e82d805dc4a12534b3d7e3fcaac606
Author: Brian Rosmaita <email address hidden>
Date: Tue Aug 21 22:24:22 2018 -0400

    Use "multihash" for data download validation

    When the Glance "multihash" is available on an image, the
    glanceclient should use it instead of MD5 to validate data
    downloads. For cases in which the multihash specifies an
    algorithm not available to the client, an option is added
    to the image-download command that will allow fallback to
    the legacy MD5 checksum verification.

    Change-Id: I4ee6e5071eca08d3bbedceda2acc170e7ed21a6b
    Closes-bug: #1788323

Changed in python-glanceclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/613350

Brian Rosmaita (brian-rosmaita)
Changed in python-glanceclient:
milestone: none → 2.14.0
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/rocky)

Reviewed: https://review.openstack.org/613350
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=395d0f157bed9dbc4e6e125f21e8b1879c26ccdb
Submitter: Zuul
Branch: stable/rocky

commit 395d0f157bed9dbc4e6e125f21e8b1879c26ccdb
Author: Brian Rosmaita <email address hidden>
Date: Tue Aug 21 22:24:22 2018 -0400

    Use "multihash" for data download validation

    When the Glance "multihash" is available on an image, the
    glanceclient should use it instead of MD5 to validate data
    downloads. For cases in which the multihash specifies an
    algorithm not available to the client, an option is added
    to the image-download command that will allow fallback to
    the legacy MD5 checksum verification.

    Change-Id: I4ee6e5071eca08d3bbedceda2acc170e7ed21a6b
    Closes-bug: #1788323
    (cherry picked from commit 8fd7e8c664e82d805dc4a12534b3d7e3fcaac606)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 2.13.0

This issue was fixed in the openstack/python-glanceclient 2.13.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 2.14.0

This issue was fixed in the openstack/python-glanceclient 2.14.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.