disk format vhdx missing in help

[Deepak Jon]

disk format type vhdx missing in help

Ref: docs.openstack.org/releasenotes/glance/newton.html

--disk-format <DISK_FORMAT>
                        Format of the disk Valid values: None, ami, ari, aki,
                        vhd, vmdk, raw, qcow2, vdi, iso

[Jaspreet Singh Rawel (jaspreetsinghrawel)]

Reproduced, it does not have disk-format vhdx in help.

(.venv) aricent1@aricent1-Precision-7510:~/jaspreet/openstack_org/python-glanceclient$ glance help image-create
usage: glance image-create [--architecture <ARCHITECTURE>]
                           [--protected [True|False]] [--name <NAME>]
                           [--instance-uuid <INSTANCE_UUID>]
                           [--min-disk <MIN_DISK>] [--visibility <VISIBILITY>]
                           [--kernel-id <KERNEL_ID>]
                           [--tags <TAGS> [<TAGS> ...]]
                           [--os-version <OS_VERSION>]
                           [--disk-format <DISK_FORMAT>]
                           [--os-distro <OS_DISTRO>] [--id <ID>]
                           [--owner <OWNER>] [--ramdisk-id <RAMDISK_ID>]
                           [--min-ram <MIN_RAM>]
                           [--container-format <CONTAINER_FORMAT>]
                           [--property <key=value>] [--file <FILE>]
                           [--progress]

Create a new image.

Optional arguments:
  --architecture <ARCHITECTURE>
                        Operating system architecture as specified in
                        http://docs.openstack.org/user-guide/common/cli-
                        manage-images.html
  --protected [True|False]
                        If true, image will not be deletable.
  --name <NAME> Descriptive name for the image
  --instance-uuid <INSTANCE_UUID>
                        Metadata which can be used to record which instance
                        this image is associated with. (Informational only,
                        does not create an instance snapshot.)
  --min-disk <MIN_DISK>
                        Amount of disk space (in GB) required to boot image.
  --visibility <VISIBILITY>
                        Scope of image accessibility Valid values: public,
                        private
  --kernel-id <KERNEL_ID>
                        ID of image stored in Glance that should be used as
                        the kernel when booting an AMI-style image.
  --tags <TAGS> [<TAGS> ...]
                        List of strings related to the image
  --os-version <OS_VERSION>
                        Operating system version as specified by the
                        distributor
  --disk-format <DISK_FORMAT>
                        Format of the disk Valid values: None, ami, ari, aki,
                        vhd, vmdk, raw, qcow2, vdi, iso
  --os-distro <OS_DISTRO>
                        Common name of operating system distribution as
                        specified in http://docs.openstack.org/user-
                        guide/common/cli-manage-images.html
  --id <ID> An identifier for the image
  --owner <OWNER> Owner of the image
  --ramdisk-id <RAMDISK_ID>
                        ID of image stored in Glance that should be used as
                        the ramdisk when booting an AMI-style image.
  --min-ram <MIN_RAM> Amount of ram (in MB) required to boot image.
  --container-format <CONTAINER_FORMAT>
                        Format of the container Valid values: None, ami, ari,
                        aki, bare, ovf, ova, docker...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/395559

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/395796

[Dean Troyer (dtroyer)]

Disk format in help is inconsistent between v1 and v2, and between create and set commands. Take this opportunity to make the --disk-format option help for all 4 commands the same.

[Steve Martinelli (stevemar)]

Dean, see related bug/patch in the previous comment. It cleans things up. https://review.openstack.org/395796

[Jaspreet Singh Rawel (jaspreetsinghrawel)]

Hello Dean,
As Steve indicated, the additional changes that you have requested have been done as part of https://review.openstack.org/395796.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395790
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=ff7fda061e4f89744b2c6d237ab913225b2ee14e
Submitter: Jenkins
Branch: master

commit ff7fda061e4f89744b2c6d237ab913225b2ee14e
Author: Jaspreet Singh Rawel <email address hidden>
Date: Thu Nov 10 02:05:54 2016 +0530

    Show disk format vhdx in help

    Currently disk format type vhdx is missing in help.

    Closes-Bug: 1635518

    Change-Id: Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395796
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=f15352f8613d73b003abc5fe4da9ff23229895c8
Submitter: Jenkins
Branch: master

commit f15352f8613d73b003abc5fe4da9ff23229895c8
Author: Steve Martinelli <email address hidden>
Date: Wed Nov 9 16:01:33 2016 -0500

    clean up image choices and help text

    Use choices for image set and image create commands, this aligns
    with our use of choices in networking commands.

    Also update the help text to match that of the networking
    commands, where we iterate through the options.

    Related-Bug: 1635518
    Change-Id: Ib4c66b06e07f1d4e5bfe1b74053f2215cccad890

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.5.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377337
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=efb5e2aa32db3f36557abdb1ddf85709b116e746
Submitter: Jenkins
Branch: master

commit efb5e2aa32db3f36557abdb1ddf85709b116e746
Author: Li Wei <email address hidden>
Date: Tue Sep 27 16:16:05 2016 +0800

    Add vhdx in disk_format

    vhdx is also a format of the disk valid value in v2 version,
    so add it in disk_format.

    Related-Bug: 1635518
    Co-Authored-By: Stuart McLaren <email address hidden>
    Change-Id: I7d82d4a4bdb180a53e86552f6f6b3bed908e6dc0

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brian Rosmaita (<email address hidden>) on branch: master
Review: https://review.openstack.org/395559
Reason: Abandoned due to inactivity, plus the bug seems to have been fixed by various other patches.