Glance Client

Codec can't encode characters

Bug #1574587 reported by Darja Shakhray on 2016-04-25

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Glance Client	Fix Released	Low	Darja Shakhray	Glance Client 1.1.1

Bug Description

client version: 2.0.0

STEP TO REPRODUCE:
try to create image with non-ascii characters for v1
glance --os-image-api-version 1 image-create --name привет

ACTUAL RESULT:
'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)

EXPECTED RESULT:
image was created

http://paste.openstack.org/show/495300/

Tags:

Darja Shakhray (dshakhray) on 2016-04-25

Changed in python-glanceclient:
assignee:	nobody → Darja Shakhray (dshakhray)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-13: Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/316054

Changed in python-glanceclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17:

Fix proposed to branch: master
Review: https://review.openstack.org/317452

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-17: Change abandoned on python-glanceclient (master)

Change abandoned by Darja Shakhray (<email address hidden>) on branch: master
Review: https://review.openstack.org/317452

Revision history for this message

Igor Marnat (imarnat) wrote on 2016-05-20:

Correct change request: https://review.openstack.org/#/c/316054/

Mike Fedosin (mfedosin) on 2016-05-23

Changed in python-glanceclient:
milestone:	none → 1.1.1
importance:	Undecided → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-23: Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/316054
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=9329ef0bc40375cd9b115415e10baf89789f56f0
Submitter: Jenkins
Branch: master

commit 9329ef0bc40375cd9b115415e10baf89789f56f0
Author: Darja Shakhray <email address hidden>
Date: Fri May 13 15:03:41 2016 +0300

Fix "Codec can't encode characters"

Headers were encoded in HTTPClient, but when glance client started
to use SessionClient this functionality was lost.

    This commit replaces static method "encode_headers" from HTTPClient
    and makes it a common function, that SessionClient can use when
    converting image meta to headers.

Change-Id: If9f8020220d2a0431b4241b38b9c83c09c0d75cb
Closes-bug: #1574587

Changed in python-glanceclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-23: Fix proposed to python-glanceclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319969

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-23: Fix merged to python-glanceclient (stable/mitaka)

Reviewed: https://review.openstack.org/319969
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=4a5567109174a05d434fe336c056ca09eda4b976
Submitter: Jenkins
Branch: stable/mitaka

commit 4a5567109174a05d434fe336c056ca09eda4b976
Author: Darja Shakhray <email address hidden>
Date: Fri May 13 15:03:41 2016 +0300

Fix "Codec can't encode characters"

Headers were encoded in HTTPClient, but when glance client started
to use SessionClient this functionality was lost.

    This commit replaces static method "encode_headers" from HTTPClient
    and makes it a common function, that SessionClient can use when
    converting image meta to headers.

    Change-Id: If9f8020220d2a0431b4241b38b9c83c09c0d75cb
    Closes-bug: #1574587
    (cherry picked from commit 9329ef0bc40375cd9b115415e10baf89789f56f0)