py26 tests require ordereddict

Bug #1520544 reported by Stuart McLaren
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
Unassigned

Bug Description

Running the py26 tests can give:

$ tox -epy26
py26 create: /mnt/sam/git/python-glanceclient/.tox/py26
py26 installdeps: -r/mnt/sam/git/python-glanceclient/requirements.txt, -r/mnt/sam/git/python-glanceclient/test-requirements.txt
py26 develop-inst: /mnt/sam/git/python-glanceclient
py26 runtests: PYTHONHASHSEED='0'
py26 runtests: commands[0] | python setup.py testr --testr-args=
running testr
running=${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./glanceclient/tests/unit} --list
/mnt/sam/git/python-glanceclient/.tox/py26/lib/python2.6/site-packages/keystoneclient/openstack/common/apiclient/__init__.py:22: DeprecationWarning: The 'keystoneclient.openstack.common.apiclient' module usage is deprecated in version '0.7.1' and will be removed in version '2.0'
  removal_version='2.0')
--- import errors ---
Failed to import test module: glanceclient.tests.unit.test_shell
Traceback (most recent call last):
  File "/mnt/sam/git/python-glanceclient/.tox/py26/lib/python2.6/site-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/mnt/sam/git/python-glanceclient/.tox/py26/lib/python2.6/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "glanceclient/tests/unit/test_shell.py", line 21, in <module>
    from ordereddict import OrderedDict
ImportError: No module named ordereddict
Non-zero exit code (2) from test listing.
error: testr failed (3)
ERROR: InvocationError: '/mnt/sam/git/python-glanceclient/.tox/py26/bin/python setup.py testr --testr-args='
________________________________________________ summary ________________________________________________
ERROR: py26: commands failed

Python 2.6 doesn't have a native OrderedDict implementation it needs the ordereddict library.

(I'm guessing gate nodes must have this installed.)

Revision history for this message
Stuart McLaren (stuart-mclaren) wrote :

And two seconds later...

Revision history for this message
Louis Taylor (kragniz) wrote :

I can reproduce this locally.

Changed in python-glanceclient:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/250751
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=8438be77d661465d0ae075f2482a1a6a7375ac44
Submitter: Jenkins
Branch: master

commit 8438be77d661465d0ae075f2482a1a6a7375ac44
Author: Stuart McLaren <email address hidden>
Date: Fri Nov 27 11:01:55 2015 +0000

    Add ordereddict requirement for py26 tests

    Tests which required OrderedDict were failing because Python 2.6 doesn't
    have a native OrderedDict implementation.

    Change-Id: Id3b0a9126279bf628022dba596d58b9e3ddb2b52
    Closes-bug: 1520544

Changed in python-glanceclient:
status: Confirmed → Fix Committed
Revision history for this message
Ian Cordasco (icordasc) wrote :

This fix was released long ago. Further, we no longer support Python 2.6

Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.