Enable hacking checks

Bug #1475054 reported by Cindy Pallares
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Wishlist
Unassigned

Bug Description

There are certain hacking rules that have been disabled for one reason or another. We should enable them.

H233 Python 3.x incompatible use of print operator
H303 no wildcard import
H404 multi line docstring should start with a summary
E265 block comment should start with '# '
H405 multi line docstring summary not separated with an empty line
E123 closing bracket does not match indentation of opening bracket's line
H238 old style class declaration, use new style (inherit from `object`)
E128 continuation line under-indented for visual indent

Changed in python-glanceclient:
assignee: nobody → Ruchi Parmar (ruchiparmar143)
Ian Cordasco (icordasc)
Changed in python-glanceclient:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: Ruchi Parmar (ruchiparmar143) → nobody
Revision history for this message
Cyril Roelandt (cyril-roelandt) wrote :

The only checks glanceclient currently ignores are https://www.flake8rules.com/rules/W504.html and https://www.flake8rules.com/rules/E731.html.

Commit cd5925bc60a5298ecc7182bf058a1b3a5bec30cf enabled:
 H233 Python 3.x incompatible use of print operator
 H303 no wildcard import
 H404 multi line docstring should start with a summary

Commit ec0f2dfd8500d230895e286462aaf69c43777038 enabled:
 E265 block comment should start with '# '
 H405 multi line docstring summary not separated with an empty line
 E123 closing bracket does not match indentation of opening bracket's line
 H238 old style class declaration, use new style (inherit from `object`)
 E128 continuation line under-indented for visual indent

I'll consider this bug fixed. Feel free to reopen if E731 and W504 are more important than I realize.

Changed in python-glanceclient:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.