OS_TENANT options should not be publicly advertised

[Ian Cordasco]

As of Kilo, we've changed all OS_TENANT_* options to OS_PROJECT_* options. The client now accepts both but should only advertise support for OS_PROJECT_{ID,NAME} and accept OS_TENANT_{ID,NAME} as a fallback.

We also likely do not need to support --os-service-type

[Dolph Mathews (dolph)]

+1. Sam-I-Am also reported that OS_PROJECT_NAME apparently wasn't being used by glanceclient - when he switched from using OS_PROJECT_NAME to OS_TENANT_NAME, the operation he was attempting suddenly succeeded.

[Kairat Kushaev (kkushaev)]

I am afraid we cannot get rid of service type as stated here service type can be used in future to receive non-standart endpoints: http://dolphm.com/openstack-keystone-service-catalog/.

[Kairat Kushaev (kkushaev)]

As you can see here: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/shell.py#L305
glanceclient is trying to use project_id/project_name when possible. So need to add warn message
I also would like to mark tenant_id/tenant_name as deprecated because now we had 2 arguments with the same goal.

[Cyril Roelandt (cyril-roelandt)]

I don't think we are advertising OS_TENANT_*:

$ git grep OS_TENANT
glanceclient/shell.py: 'OS_PROJECT_NAME', 'OS_TENANT_NAME'))
glanceclient/shell.py: 'OS_PROJECT_ID', 'OS_TENANT_ID'))
glanceclient/tests/unit/test_shell.py: 'OS_TENANT_NAME': DEFAULT_TENANT_NAME,
glanceclient/tests/unit/test_shell.py: self.assertEqual(self.auth_env['OS_TENANT_NAME'],
glanceclient/tests/unit/test_shell.py: if 'OS_TENANT_NAME' in os.environ:
glanceclient/tests/unit/test_shell.py: self.make_env(exclude='OS_TENANT_NAME')
glanceclient/tests/unit/test_shell.py: if 'OS_TENANT_NAME' in os.environ:
glanceclient/tests/unit/test_shell.py: self.make_env(exclude='OS_TENANT_NAME')
glanceclient/tests/unit/v1/test_shell.py: 'OS_TENANT_ID': 'tenant_id',
glanceclient/tests/unit/v2/test_shell_v2.py: 'OS_TENANT_ID': 'tenant_id',

As of 9e8fcdb, we are only using OS_TENANT_* for compatibility reasons. I'll consider this bug as having been fixed a while ago. Feel free to reopen if you think this is still an issue.