python-clients should reuse parameters provided by Keystone

Bug #1434105 reported by Pawel Koniszewski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Invalid
Undecided
Unassigned
python-cinderclient
Fix Released
Low
Michal Dulko
python-heatclient
In Progress
Medium
Unassigned
python-neutronclient
Invalid
Undecided
Unassigned

Bug Description

python-keystoneclient provides some arguments in shared session object , e.g.

--os-cert
--os-cacert
--timeout
--os-key

All clients should use this logic instead of registering own CLI attributes.

Changed in python-glanceclient:
assignee: nobody → Pawel Koniszewski (pawel-koniszewski)
Changed in python-cinderclient:
assignee: nobody → Michal Dulko (michal-dulko-f)
status: New → In Progress
Changed in python-glanceclient:
status: New → In Progress
Grzegorz Grasza (xek)
Changed in python-neutronclient:
assignee: nobody → Grzegorz Grasza (xek)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170370

Grzegorz Grasza (xek)
Changed in python-heatclient:
assignee: nobody → Grzegorz Grasza (xek)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170411

Mike Perez (thingee)
Changed in python-cinderclient:
assignee: Michal Dulko (michal-dulko-f) → nobody
status: In Progress → Triaged
importance: Undecided → Low
Changed in python-heatclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/170370
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in python-cinderclient:
assignee: nobody → Juergen Leopold (leopoldj)
Changed in python-cinderclient:
assignee: Juergen Leopold (leopoldj) → Michal Dulko (michal-dulko-f)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/165833
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=891ef3e71e5df30f3c3e97a806dc116c1677568b
Submitter: Jenkins
Branch: master

commit 891ef3e71e5df30f3c3e97a806dc116c1677568b
Author: Michal Dulko <email address hidden>
Date: Thu Mar 19 15:27:16 2015 +0100

    Use shared shell arguments provided by Session

    The cinderclient implemented it's own version of the CLI arguments that
    are now provided by keystoneclient's session object. This changeset
    converts cinder over to utilizing the shared argument registration.

    Closes-Bug: 1434105
    Change-Id: I72b16aab909d72a47097434436093e616667634a

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.4.0
status: Fix Committed → Fix Released
Changed in python-glanceclient:
assignee: Pawel Koniszewski (pawel-koniszewski) → nobody
Grzegorz Grasza (xek)
Changed in python-heatclient:
assignee: Grzegorz Grasza (xek) → nobody
Changed in python-neutronclient:
assignee: Grzegorz Grasza (xek) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

In neutronclient, https://review.openstack.org/#/c/242096/ will address this bug.

Revision history for this message
Kairat Kushaev (kkushaev) wrote :
Changed in python-glanceclient:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 1.4.0

This issue was fixed in the openstack/python-cinderclient 1.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-heatclient (master)

Change abandoned by Grzegorz Grasza (xek) (<email address hidden>) on branch: master
Review: https://review.openstack.org/170411

Revision history for this message
Akihiro Motoki (amotoki) wrote :

The situation has changed during the efforts of supporting keystone v3.
neuton CLI supports them now.
https://github.com/openstack/python-neutronclient/blob/master/neutronclient/shell.py#L529

Changed in python-neutronclient:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.