v1 list operation causes sockets to leak

[Louis Taylor]

Ever since the move to the requests library, services which use glanceclient are leaking sockets each time a list operation is performed.

To reproduce, on a devstack machine run:

    $ nova image-list

Each time a list operation is done, the list of open connections between nova and glance will increase:

    $ lsof -i | grep 9292

[Louis Taylor (kragniz)]

Review: https://review.openstack.org/#/c/157516/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157516
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=f98ab688eff8fff4bdb5f650da3516715d62f232
Submitter: Jenkins
Branch: master

commit f98ab688eff8fff4bdb5f650da3516715d62f232
Author: Louis Taylor <email address hidden>
Date: Thu Feb 19 18:39:20 2015 +0000

    Fix leaking sockets after v1 list operation

    Since the move to using the requests library, v1 list operations keep
    the connection open to the glance server. This is normally closed by the
    garbage collector if it is not explicitly closed, however the paginate
    function used by the list method had a circular reference preventing it
    from ever being collected during the lifecycle of a service consuming
    glanceclient.

    This is problematic, since it causes long running nova processes to run
    out of file descriptors for new connections.

    This patch makes paginate() non-recursive, which allows the connection
    to be freed.

    Change-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0
    Closes-Bug: 1423939