Auth plugin tests running only on Keystone v2 environment variables

Bug #1419788 reported by Michal Dulko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
Michal Dulko

Bug Description

Line 72 of tests/test_shell.py:
    def make_env(self, exclude=None, fake_env=FAKE_V2_ENV):

This specifies fake_env explicitly as Keystone v2 env and ShellTestWithKeystoneV3Auth doesn't replace it so all tests are running on V2 fake env only.

Ramaraja (ramaraja-r)
Changed in python-glanceclient:
assignee: nobody → Ramaraja (ramaraja-r)
Revision history for this message
Michal Dulko (michal-dulko-f) wrote :

Oh, sorry. I've fixed this in https://review.openstack.org/#/c/116894/, not sure why Launchpad didn't catch that.

Changed in python-glanceclient:
assignee: Ramaraja (ramaraja-r) → Michal Dulko (michal-dulko-f)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/116894
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=b47925eda1a674ee2497ec627eee089fbd6e1ac0
Submitter: Jenkins
Branch: master

commit b47925eda1a674ee2497ec627eee089fbd6e1ac0
Author: Michal Dulko <email address hidden>
Date: Mon Feb 9 14:32:17 2015 +0100

    Unit tests covering missing username or password

    After fixing message displayed when client is executed without
    required environment variables exported (OS_USERNAME, OS_PASSWORD,
    OS_PROJECT_NAME, OS_AUTH_URL) regression tests should be added. I've
    also fixed an issue causing tests using make_env method to always use
    FAKE_V2_ENV, even in ShellTestWithKeystoneV3Auth.

    Change-Id: I800c8fa11ee45d19f179bd030426db86a93d9f6a
    Closes-Bug: 1419788
    Partial-Bug: 1355252

Changed in python-glanceclient:
status: In Progress → Fix Committed
Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.