Error when using glance image-download with progress flag

[Itzik Brown]

Version
=======
Juno rc1 on RHEL7
python-glance-store-0.1.8-1.el7.centos.noarch
openstack-glance-2014.2-1.el7.centos.noarch
python-glance-2014.2-1.el7.centos.noarch
python-glanceclient-0.14.1-1.el7.centos.noarch

Description
===========
When running the following command:
# glance image-download --file image1 image1 --progress

I get the following error:
object of type 'generator' has no len()

[John Schwarz (jschwarz)]

Confirmed this bug occurs.

[Gaëtan Trellu (goldyfruit)]

Same for me but on RHEL 7 + OSP 5 (IceHouse)

[Louis Taylor (kragniz)]

I can also confirm for the v2 api.

$ glance --os-image-api-version 2 image-download --file image1 image1 --progress
object of type 'generator' has no len()

[Louis Taylor (kragniz)]

This was broken in the move to requests (https://review.openstack.org/#/c/78269/).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/132432

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/132432
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=df02ee8e2a10d2f37a9c013dec157c88b8dce49d
Submitter: Jenkins
Branch: master

commit df02ee8e2a10d2f37a9c013dec157c88b8dce49d
Author: Louis Taylor <email address hidden>
Date: Sat Nov 1 20:49:03 2014 +0000

    Fix Requests breaking download progress bar

    The move to the requests library (dbb242b) broke the progress bar during
    downloading an image with --progress enabled, due to requests returning
    a generator, which has no __len__ function. This patch adds an iterable
    wrapper which provides the length, sourced from Content-Length headers.

    Closes-Bug: #1384664

    Change-Id: I48598a824396bc6e7cba69eb3ce32e7c8f30a18a

[Zoltan Arnold Nagy (zoltan)]

I'm seeing this at Kilo with the following package:

1:0.15.0-0ubuntu1~cloud0

Here is the output:

root@ng:/tmp# glance --debug image-download --file sysbench-image.raw --progress 075eb535-376f-44a0-aad1-a8bb9c1b775a
[...]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/glanceclient/shell.py", line 637, in main
    args.func(client, args)
  File "/usr/lib/python2.7/dist-packages/glanceclient/v1/shell.py", line 150, in do_image_download
    body = progressbar.VerboseIteratorWrapper(body, len(body))
TypeError: object of type 'generator' has no len()
object of type 'generator' has no len()
root@ng:/tmp#

[wobs (shengboyu)]

where could i get this correction?