'--public' ignored on image create

[Stuart McLaren]

Currently, if '--public' is specified, an image is created but
it is not marked as public:

    $ glance image-create --public --name minus-minus-public --disk-format raw
    +------------------+--------------------------------------+
    | Property | Value |
    +------------------+--------------------------------------+
    .
    .
    .
    | is_public | False |
    .
    .
    .
    +------------------+--------------------------------------+

This is inconsistent.

[Wlodzimierz Borkowski (borqosky)]

Hi, I have looked on docs http://docs.openstack.org/cli-reference/content/glanceclient_commands.html, and there is --is-public {True | False} values when glance image-create executing.
Might be a typo in your command ?

[Stuart McLaren (stuart-mclaren)]

> Might be a typo in your command ?

No.

This bug is related to the fact that the original option was called '--public' and this has been deprecated in favour of the new option '--is-public'.

The old option is still recognised (ie no error is raised) but it does not set the image to be public -- which is inconsistent behaviour.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/131509

[Wlodzimierz Borkowski (borqosky)]

Hi Dominik, the patch https://review.openstack.org/#/c/126910/ was already done to this issue, but unfortunelly it's not linked here. I've got this issue as well

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/126910
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=597da8aa5514b7e8ba05426ac3c36f09597b8b8a
Submitter: Jenkins
Branch: master

commit 597da8aa5514b7e8ba05426ac3c36f09597b8b8a
Author: Stuart McLaren <email address hidden>
Date: Wed Oct 8 13:44:58 2014 +0000

    '--public' ignored on image create

    Currently, if '--public' is specified, an image is created but
    it is not marked as public:

    $ glance image-create --public --name minus-minus-public --disk-format raw \
     --container-format bare < /etc/fstab
    +------------------+--------------------------------------+
    | Property | Value |
    +------------------+--------------------------------------+
    .
    .
    .
    | is_public | False |
    .
    .
    .
    +------------------+--------------------------------------+

    This is inconsistent.

    '--public' has been deprecated for some time, and has
    been removed from devstack (https://review.openstack.org/#/c/39323/),
    so we can finally get rid of it.

    We now raise the standard error for unsupported arguments.

    Change-Id: I15d16f690f9bd92b4cefbc8ed36ed2d171ff22f3
    Closes-bug: #1378844

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ian Cordasco (<email address hidden>) on branch: master
Review: https://review.openstack.org/131509
Reason: This is a duplicate of I15d16f690f9bd92b4cefbc8ed36ed2d171ff22f3 which has already merged and fixed the bug