Image update incorrectly sets headers

Bug #1318079 reported by Maithem
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
Maithem

Bug Description

In line : https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L271 if kwargs doesnt have the 'purge_props' key, then hdrs['x-glance-registry-purge-props'] won't be set to 'false'. If the key 'purge_props' isn't in kwargs then an exception would be thrown and

 else:
            hdrs['x-glance-registry-purge-props'] = purge_props

won't be evaluated.

Expected:
The glance registry headers should be set correctly in order to expect consistent results.

Maithem (maithem)
summary: - Image update incorrectly purges metadata
+ Image update incorrectly sets headers
Changed in python-glanceclient:
assignee: nobody → Maithem (maithem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/93162

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-glanceclient (master)

Change abandoned by Maithem (<email address hidden>) on branch: master
Review: https://review.openstack.org/93162

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/93162
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=cddc37dcab80eec3eb3b9a2849c09c1ae3892381
Submitter: Jenkins
Branch: master

commit cddc37dcab80eec3eb3b9a2849c09c1ae3892381
Author: Maithem <email address hidden>
Date: Fri May 9 17:25:05 2014 -0700

    Set purge-props header correctly in image update

    Currently when an image is updated, the purge property
    header is only set to true in some cases, but when
    required it isn't set to false

    Change-Id: I885a82643d2620f393f21c36b3ad95cb7ed43f2c
    Closes-Bug: 1318079

Changed in python-glanceclient:
status: In Progress → Fix Committed
Louis Taylor (kragniz)
Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.