Glance Client

log_curl_request function in glance/common/http.py has no test coverage

Bug #1174339 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Low
Michal Dulko
Glance Client 1.0.0 "1.0.0"

Bug Description

the function log_curl_request in glance/common/http.py has no test coverage. This means that the debug output for showing the curl commands has no regression tests.

Tests could easily be added in tests/test_http.py

Deepak Yalla (yalla-deepakmca)
Changed in python-glanceclient:
assignee: nobody → Deepak Yalla (yalla-deepakmca)
Deepak Yalla (yalla-deepakmca)
Changed in python-glanceclient:
status: New → Confirmed
status: Confirmed → In Progress
Deepak Yalla (yalla-deepakmca)
Changed in python-glanceclient:
assignee: Deepak Yalla (yalla-deepakmca) → nobody
Mukul Patel (mukul18)
Changed in python-glanceclient:
assignee: nobody → Mukul Patel (mukul18)
Revision history for this message
Wei Wang (damon-devops) wrote :

Hi Mukul,

Are you still in work on this?

Damon

Mukul Patel (mukul18)
Changed in python-glanceclient:
assignee: Mukul Patel (mukul18) → nobody
Michal Dulko (michal-dulko-f)
Changed in python-glanceclient:
assignee: nobody → Michal Dulko (michal-dulko-f)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/105464

Kamil Rykowski (kamil-rykowski)
tags: added: testing
removed: test-coverage
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/105464
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=76c9f68ab62470378bdfd8cb92572425693a2f9d
Submitter: Jenkins
Branch: master

commit 76c9f68ab62470378bdfd8cb92572425693a2f9d
Author: Michal Dulko <email address hidden>
Date: Tue Apr 14 10:00:51 2015 +0200

    Add unit tests for log_curl_request

    Add 5 new tests that check if log_curl_request method produces proper
    curl commands and add again an old test checking this method for
    unicode support.

    Change-Id: I64caad18d537d727835f3a7ada010ec45b20638a
    Closes-Bug: 1174339

Changed in python-glanceclient:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.