Use oslo's strutils for encoding / decoding strings

Bug #1172253 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Low
Flavio Percoco

Bug Description

Currently, Glance's client is using its own implementation for encoding / decoding strings. Since this was merged into oslo, it makes sense to use that instead.

Changed in python-glanceclient:
assignee: nobody → Flavio Percoco (flaper87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30070

Changed in python-glanceclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/30070
Committed: http://github.com/openstack/python-glanceclient/commit/7818387d4ac4c4a20899fc4470da86c5bcabf183
Submitter: Jenkins
Branch: master

commit 7818387d4ac4c4a20899fc4470da86c5bcabf183
Author: Flaper Fesp <email address hidden>
Date: Wed May 22 11:31:25 2013 +0200

    Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)

    Glanceclient implemented both functions before they landed into oslo.
    Since both functions are already in oslo, it is now possible to pull
    them in.

    There's a small difference between glance's implementation and oslo's,
    that is the later does not convert non-str objects - int, bool - to str
    before trying to decode / encode them. This patch takes care of that
    where necessary, more precisely, while encoding headers before doing a
    new request.

    Fixes bug: #1172253

    Change-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b

Changed in python-glanceclient:
status: In Progress → Fix Committed
Louis Taylor (kragniz)
Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.