"httplib.InvalidUrl" should be "httplib.InvalidURL"

Bug #1048698 reported by Stuart McLaren on 2012-09-10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stuart McLaren

Bug Description

According to


the httplib.InvalidUrl exception should be capitalized, ie httplib.InvalidURL

    def get_connection(self):
        _class = self.connection_params[0]
            return _class(*self.connection_params[1],
        except httplib.InvalidUrl:
            raise exc.InvalidEndpoint()

Changed in python-glanceclient:
assignee: nobody → Stuart McLaren (stuart-mclaren)

Fix proposed to branch: master
Review: https://review.openstack.org/12718

Changed in python-glanceclient:
status: New → In Progress
Brian Waldon (bcwaldon) on 2012-09-10
Changed in python-glanceclient:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/12718
Committed: http://github.com/openstack/python-glanceclient/commit/61b359efa836b5e25d85892e2772fd9856062103
Submitter: Jenkins
Branch: master

commit 61b359efa836b5e25d85892e2772fd9856062103
Author: Stuart McLaren <email address hidden>
Date: Mon Sep 10 14:57:45 2012 +0000

    get_connection should raise httplib.InvalidURL

    In http.py the exception raised in get_connection
    should be httplib.InvalidURL rather than httplib.InvalidUrl.

    Fix for bug 1048698.

    Change-Id: I7f18321fe7d8669b3b95bf823273ee8ae6961661

Changed in python-glanceclient:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon) on 2012-09-11
Changed in python-glanceclient:
milestone: none → v0.5.1
Brian Waldon (bcwaldon) on 2012-09-11
Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers