Deleting managed recordsets should provide meaningful exception message.

Bug #1511230 reported by sonu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Low
Alex Barclay

Bug Description

vyom@vyom:~$ openstack zone list
+--------------------------------------+------------+---------+------------+--------+--------+
| id | name | type | serial | status | action |
+--------------------------------------+------------+---------+------------+--------+--------+
| 78dd3e3d-8535-43d9-a05e-abac3332e4fc | temp.org. | PRIMARY | 1446091304 | ACTIVE | NONE |
| fdc7012f-a013-4695-aa22-d8bfc82a31ed | temp1.org. | PRIMARY | 1446031668 | ACTIVE | NONE |
+--------------------------------------+------------+---------+------------+--------+--------+
vyom@vyom:~$ openstack recordset list 78dd3e3d-8535-43d9-a05e-abac3332e4fc
+--------------------------------------+-----------+------+-----------------------------------------------------------------+
| id | name | type | records |
+--------------------------------------+-----------+------+-----------------------------------------------------------------+
| d8de08e0-2c3c-405b-b412-bc2e793b14c6 | temp.org. | NS | ns1.devstack.org. |
| f1ef04b3-4c60-4a66-b54b-b18f76778cdf | temp.org. | SOA | ns1.devstack.org. abc.gmail.com. 1446091304 3600 600 86400 3600 |
+--------------------------------------+-----------+------+-----------------------------------------------------------------+

While we try to delete NS records we get exception message as follows :
vyom@vyom:~$ openstack recordset delete 78dd3e3d-8535-43d9-a05e-abac3332e4fc d8de08e0-2c3c-405b-b412-bc2e793b14c6
Managed records may not be updated

This message should be something like
"Managed records can not be deleted"
  or
"Deleting a NS recordset is not allowed"

megha (tmegha247)
Changed in python-designateclient:
assignee: nobody → megha (tmegha247)
Tim Simmons (timsim)
affects: python-designateclient → designate
Changed in designate:
status: New → Triaged
summary: - 'openstack recordset delete ' command should provide meaningful
- exception message.
+ Deleting managed recordsets should provide meaningful exception message.
Changed in designate:
importance: Undecided → Low
status: Triaged → Confirmed
Revision history for this message
Tim Simmons (timsim) wrote :

This error message comes from within Designate, and a case should be added for Deleting to get a better message to clients/users.

Changed in designate:
assignee: megha (tmegha247) → Alex Barclay (9lex)
milestone: none → mitaka-2
status: Confirmed → Triaged
Alex Barclay (9lex)
Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/271577

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/271577
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=1a6a6fb9a3f4a31239061baf347daae03305a9c1
Submitter: Jenkins
Branch: master

commit 1a6a6fb9a3f4a31239061baf347daae03305a9c1
Author: Alex Barclay <email address hidden>
Date: Fri Jan 22 16:06:04 2016 -0800

    Fixes wording of exceptions for delete

    Updated the wording of exceptions that prevent the deletion of
    managed records. Original message indicated that user was
    unable to update when the user actually requested a delete.
    New message is "Managed records may not be deleted"
    Both exceptions in designate/central/service.py

    Change-Id: I27395999b2002374a74bddad71333f508354f37b
    Closes-Bug: #1511230

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/273160

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/273160
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=6b412e8647beae0e6e9215ab640ec50ff750d665
Submitter: Jenkins
Branch: stable/liberty

commit 6b412e8647beae0e6e9215ab640ec50ff750d665
Author: Alex Barclay <email address hidden>
Date: Fri Jan 22 16:06:04 2016 -0800

    Fixes wording of exceptions for delete

    Updated the wording of exceptions that prevent the deletion of
    managed records. Original message indicated that user was
    unable to update when the user actually requested a delete.
    New message is "Managed records may not be deleted"
    Both exceptions in designate/central/service.py

    Change-Id: I27395999b2002374a74bddad71333f508354f37b
    Closes-Bug: #1511230

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b3

This issue was fixed in the openstack/designate 2.0.0.0b3 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/designate 1.0.2

This issue was fixed in the openstack/designate 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/designate 1.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.