socket timeout parameter is missing
Bug #1469739 reported by
Monty Taylor
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-designateclient |
Fix Released
|
Medium
|
Federico Ceratto | ||
Bug Description
The other client libs have a Client constructor parameter called "timeout" which gets carried through to pass to the requests constructor timeout parameter. It sets the socket-level timeout, which is, sadly, something we've experienced in various places in infra.
It would be stellar if designate had this too!
| Changed in python-designateclient: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: low-hanging-fruit |
| Changed in python-designateclient: | |
| assignee: | nobody → Federico Ceratto (federico-ceratto) |
| Changed in python-designateclient: | |
| status: | Triaged → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to python-designateclient (master) | #1 |
| Changed in python-designateclient: | |
| status: | In Progress → Fix Committed |
| Changed in python-designateclient: | |
| milestone: | none → 1.5.0 |
| status: | Fix Committed → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/python-designateclient 1.5.0 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 2ec96b6672a9282
Author: Federico Ceratto <email address hidden>
Date: Thu Jul 2 15:59:39 2015 +0100
Implement socket timeout in v1
Add endpoint_override keyword to v2.Client() and check for the
session argument in DesignateAdapter()
Add unit test, fix minor typos
Change-Id: I038ec7b0d1fead
Closes-Bug: 1469739