python3-dbusmock / test_no_adapters test fails with bluez 5.45

[Jean-Baptiste Lallement]

https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#bluez
http://autopkgtest.ubuntu.com/packages/p/python-dbusmock/artful/amd64

With bluez 5.45 python3-dbusmock tests fail with:

======================================================================
FAIL: test_no_adapters (__main__.TestBlueZ5)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test_bluez5.py", line 107, in test_no_adapters
    self.assertEqual([l for l in out if 'Waiting to connect' not in l], [])
AssertionError: Lists differ: ['org.freedesktop.DBus.Mock.MethodCalled', 'registered', 'unregistered'] != []

First list contains 3 additional elements.
First extra element 0:
'org.freedesktop.DBus.Mock.MethodCalled'

- ['org.freedesktop.DBus.Mock.MethodCalled', 'registered', 'unregistered']
+ []

----------------------------------------------------------------------

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: bluez 5.45-0ubuntu1
ProcVersionSignature: Ubuntu 4.10.0-22.24-generic 4.10.15
Uname: Linux 4.10.0-22-generic x86_64
ApportVersion: 2.20.5-0ubuntu4
Architecture: amd64
CurrentDesktop: GNOME
Date: Wed Jun 7 18:01:13 2017
InstallationDate: Installed on 2013-09-03 (1372 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130902)
InterestingModules: bnep bluetooth
MachineType: ASUSTeK COMPUTER INC. UX32VD
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.10.0-22-generic.efi.signed root=UUID=1004226d-a9db-46c7-bd28-eca0806c12f2 ro pcie_aspm=force drm.vblankoffdelay=1 i915.semaphores=1 init=/lib/systemd/systemd-bootchart
SourcePackage: bluez
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 01/29/2013
dmi.bios.vendor: American Megatrends Inc.
dmi.bios.version: UX32VD.214
dmi.board.asset.tag: ATN12345678901234567
dmi.board.name: UX32VD
dmi.board.vendor: ASUSTeK COMPUTER INC.
dmi.board.version: 1.0
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 10
dmi.chassis.vendor: ASUSTeK COMPUTER INC.
dmi.chassis.version: 1.0
dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrUX32VD.214:bd01/29/2013:svnASUSTeKCOMPUTERINC.:pnUX32VD:pvr1.0:rvnASUSTeKCOMPUTERINC.:rnUX32VD:rvr1.0:cvnASUSTeKCOMPUTERINC.:ct10:cvr1.0:
dmi.product.name: UX32VD
dmi.product.version: 1.0
dmi.sys.vendor: ASUSTeK COMPUTER INC.
hciconfig:

rfkill:
 0: phy0: Wireless LAN
  Soft blocked: no
  Hard blocked: no
upstart.bluetooth.override: manual

[Daniel van Vugt (vanvugt)]

Interesting. The tests all passed in my local builds...

[Daniel van Vugt (vanvugt)]

Bisected. The test failure started with bluez 5.45, and specifically in:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=6db3470c2ea161b4b808ad1fc80dfd7e014fd359

However this appears to be a feature and not a bug. So the actual bug is just a poor test case in python3-dbusmock, expecting the bluetoothctl log to always be silent other than a very specific message. That's just not true in BlueZ 5.45 and it's not a bug...

[Daniel van Vugt (vanvugt)]

Upstream fix proposed:

https://github.com/martinpitt/python-dbusmock/pull/29/commits/39ad4ac96ba55b05afa2919b87a4682c8994ee61

[Martin Pitt (pitti)]

Thanks Daniel! PR merged upstream. There are a few other test deprecation warnings/failures I'm looking into before doing a release.

[Martin Pitt (pitti)]

I released 0.16.8 upstream and uploaded it to Debian unstable, from where it should autosync into Ubuntu devel soon.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-dbusmock - 0.16.8-1

---------------
python-dbusmock (0.16.8-1) unstable; urgency=medium

  * New upstream release:
    - bluez5 template tests: Fix failure of test_no_adapters with BlueZ 5.45.
      (LP: #1696480)

 -- Martin Pitt <email address hidden> Mon, 12 Jun 2017 13:57:49 +0200