logind template doesn't properly add its properties

[Philip Chimento]

When instantiating a logind template with spawn_server_template(), you will see this log message:

ERROR:dbus.service:Unable to append ({'IdleAction': 'ignore', 'PreparingForSleep': False, 'IdleHint': False, 'IdleSinceHint': None, 'PreparingForShutdown': False},) to message with signature a{sv}: <type 'exceptions.TypeError'>: Don't know which D-Bus type to use to encode type "NoneType"

This should be fixed by changing None to 0 on line 70 of logind.py: https://gitorious.org/python-dbusmock/python-dbusmock/source/fe9c838adbb0e1d4b85f566ec0d48ff5584f70c3:dbusmock/templates/logind.py#L70

It can be worked around by specifying parameters={'IdleSinceHint': 0} to the spawn_server_template() call.

[Martin Pitt (pitti)]

Thanks for pointing out! Fixed in https://gitorious.org/python-dbusmock/python-dbusmock/commit/3be081b2

But OOI, I don't see that error message, neither in the test suite nor when instantiating it manually with

  DBUS_SYSTEM_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS python3 -m dbusmock -t logind
  DBUS_SYSTEM_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS loginctl

How did you trigger this? I'd like to reproduce that in a test case.

Thanks!

[Philip Chimento (philip-chimento)]

Thanks for fixing! This test case triggers it for me:

import dbus
import unittest

import dbusmock

class Test(dbusmock.DBusTestCase):
    @classmethod
    def setUpClass(klass):
        """Set up a mock system bus."""
        klass.start_system_bus()
        klass.dbus_con = klass.get_dbus(system_bus=True)

    def setUp(self):
        (self.login_popen, self.login_obj) = self.spawn_server_template('logind')

    def tearDown(self):
        self.login_popen.terminate()
        self.login_popen.wait()

    def test_case_for_bug(self):
        iface = dbus.Interface(self.dbus_con.get_object('org.freedesktop.login1',
            '/org/freedesktop/login1'), 'org.freedesktop.DBus.Properties')
        iface.GetAll('org.freedesktop.login1.Manager')

if __name__ == '__main__':
    unittest.main()

[Philip Chimento (philip-chimento)]

By the way, on your fix it looks like you might have mistakenly assigned all three property default values to IdleSinceHint.

[Martin Pitt (pitti)]

Argh, I'm a copy&paste muppet. Fixed in https://gitorious.org/python-dbusmock/python-dbusmock/commit/6378ffb07, thanks for pointing out! Will add the test case on Monday.

[Martin Pitt (pitti)]

Test case added in https://gitorious.org/python-dbusmock/python-dbusmock/commit/6e4ba903

Thanks!

[Philip Chimento (philip-chimento)]

Awesome!

[Martin Pitt (pitti)]

Released in https://launchpad.net/python-dbusmock/trunk/0.11.1

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-dbusmock - 0.11.1-1

---------------
python-dbusmock (0.11.1-1) unstable; urgency=medium

  * New upstream release:
    - logind template: Fix type of IdleSinceHint property, and add
      IdleSinceHintMonotonic and IdleActionUSec properties. (LP: #1348437)
    - NetworkManager template: Add "Devices" and "AccessPoints" properties of
      NetworkManager 0.9.10. (LP: #1328579)

 -- Martin Pitt <email address hidden> Fri, 08 Aug 2014 08:17:34 +0200