invalid day of week range accepted

Bug #1591696 reported by Arno Dekker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-crontab
Fix Committed
Medium
Martin Owens

Bug Description

Entering for example 3-1 as days of week (wednesday until monday) is considered valid input, but not accepted by any cron as far as I can tell.

Revision history for this message
Martin Owens (doctormo) wrote :

The creation of a crontab with an incorrect range produces a corrected range when written.

What, if any, error would you expect in the situation?

Thanks for the bug report.

Changed in python-crontab:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Arno Dekker (adekker) wrote :

Right, I only call the syntax check part and then write the crontab line myself if validated, without any rewrite.

On one hand it is handy that it is rewritten, on the other hand you accept something as valid, which is not really a valid cron entry.

If you intent to change it, maybe some warning state/message that it will be rewritten to ..."

Now I know that a rewrite is done, I can understand it has not been reported. If you prefer to leave it as it is now, I can live with that.

Revision history for this message
Martin Owens (doctormo) wrote :

I added a warning and made sure there's a test for this situation.

Changed in python-crontab:
assignee: nobody → Martin Owens (doctormo)
milestone: none → 2.2
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.