variables shell integration tests are repeated code

Bug #1670446 reported by Thomas Maddox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Craton's Python Client
Fix Released
Medium
Thomas Maddox

Bug Description

https://github.com/openstack/python-cratonclient/blob/master/cratonclient/tests/integration/shell/v1/test_cells_shell.py#L334-L407 is a repeated pattern for each resource. We can do better. Let's extract these to the base class and just fill in the necessary resource/ID attributes for the concrete classes and let them inherit the tests from base.

Revision history for this message
Thomas Maddox (thomas-maddox) wrote :
Changed in python-cratonclient:
assignee: nobody → Thomas Maddox (thomas-maddox)
importance: Undecided → Medium
status: New → In Progress
milestone: none → v0.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cratonclient (master)

Reviewed: https://review.openstack.org/442099
Committed: https://git.openstack.org/cgit/openstack/python-cratonclient/commit/?id=40e6be281c0139690c1786c3ad0acc4c51c68968
Submitter: Jenkins
Branch: master

commit 40e6be281c0139690c1786c3ad0acc4c51c68968
Author: Thomas Maddox <email address hidden>
Date: Mon Mar 6 18:09:06 2017 +0000

    Ensure consistent vars shell behavior across resources

    This patch DRYs out the variables shell test cases
    even further to ensure the same pattern of behavior
    across all resources' variables shell
    implementations.

    Closes-Bug: 1670446

    Change-Id: I69cc3ac025dfdcd0b0bbe2084125014cb7f659e9

Changed in python-cratonclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.