Client is missing functions to get named objects

Bug #1386407 reported by Janet Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-congressclient
Fix Released
Undecided
Unassigned

Bug Description

The python-congressclient's client API does not have the following available:

- Read policy properties (v1/policies/<policy-id>)
- Read policy table properties (v1/policies/<policy-id>/tables/<table-id>)
- Read data source table properties (v1/data-sources/<ds-id>/tables/<table-id>)

Tim Hinrichs (thinrichs)
Changed in congress:
importance: Undecided → Low
Aaron Rosen (arosen)
no longer affects: congress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-congressclient (master)

Reviewed: https://review.openstack.org/149728
Committed: https://git.openstack.org/cgit/stackforge/python-congressclient/commit/?id=a77ea7c8edc76890faee5ea2071b64aead6c880f
Submitter: Jenkins
Branch: master

commit a77ea7c8edc76890faee5ea2071b64aead6c880f
Author: Amey Bhide <email address hidden>
Date: Fri Jan 23 11:11:01 2015 -0800

    Add read policy and datasource table properties

    Closes-Bug: #1386407
    Change-Id: Ida8c0976b290f4fc0a2f420a0d771148e644907f

Changed in python-congressclient:
status: New → Fix Committed
Revision history for this message
Janet Yu (jwy) wrote :

Adding reminder - show_policy() exists but doesn't work:

 curl -X GET localhost:1789/v1/policies/classification
{"error": {"message": "Not found", "error_data": null, "error_code": 404}}

And function to read data source properties (v1/data-sources/<ds-id>) is missing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-congressclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/158515

Revision history for this message
Amey Bhide (abhide) wrote :

Hey Janet,
For show_policy(): https://review.openstack.org/158515

I guess for datasource properties, you might want to look at "openstack congress driver config show"

Revision history for this message
Janet Yu (jwy) wrote :

@Amey: I realized that show_policy() wasn't working for me for the "classification" policy because I need to use the policy's id instead of the name. However, the system policies all have an id of "None", as described in https://bugs.launchpad.net/congress/+bug/1411014, so show_policy() currently won't work for those policies. This can be addressed by fixing the aforementioned bug.

For data source properties, a data source is an instantiation of a driver. Their properties will be somewhat different. As far as this bug is concerned, a show_datasource() function needs to be added to python-congressclient/congressclient/v1/client.py.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-congressclient (master)

Reviewed: https://review.openstack.org/158515
Committed: https://git.openstack.org/cgit/stackforge/python-congressclient/commit/?id=01b0b28400ee409d31de28c207b613399112c439
Submitter: Jenkins
Branch: master

commit 01b0b28400ee409d31de28c207b613399112c439
Author: Amey Bhide <email address hidden>
Date: Mon Feb 23 16:01:32 2015 -0800

    Adds CLI command for show policy

    Closes-Bug: #1386407
    Change-Id: I230b7af1d48eba368c718aef378e725de5234391

Tim Hinrichs (thinrichs)
Changed in python-congressclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.