collect-timing option doesn't show anything

Bug #1960337 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Low
Gorka Eguileor

Bug Description

When we run "cinder help" we can see that there is a --collect-timing option:

  --collect-timing Collect per-API call timing information.

But when we run a command with that option we don't see any timing output, unlike the "--timing" option from OSC that does display the timings.

Changed in python-cinderclient:
status: New → In Progress
Changed in python-cinderclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-cinderclient/+/828380
Committed: https://opendev.org/openstack/python-cinderclient/commit/da5ecebb3353618542aa84c2078b03f1a9f6ad83
Submitter: "Zuul (22348)"
Branch: master

commit da5ecebb3353618542aa84c2078b03f1a9f6ad83
Author: Gorka Eguileor <email address hidden>
Date: Tue Feb 8 17:51:17 2022 +0100

    Add support for collect-timing option

    When we run "cinder help" we can see that there is a --collect-timing
    option:

      --collect-timing Collect per-API call timing information.

    This is a keystone session option that we are not currently acting on
    from a user perspective.

    This patch adds support for this option, and we'll be able to see the
    timing in a similar way as we do with OSC:

    $ cinder --collect-timing api-version
    +------+---------+---------+-------------+
    | ID | Status | Version | Min_version |
    +------+---------+---------+-------------+
    | v3.0 | CURRENT | 3.66 | 3.0 |
    +------+---------+---------+-------------+
    +--------+------------------------------------------------+----------+
    | method | url | seconds |
    +--------+------------------------------------------------+----------+
    | GET | http://192.168.121.243/identity | 0.003591 |
    | POST | http://192.168.121.243/identity/v3/auth/tokens | 0.016649 |
    | GET | http://192.168.121.243/volume/ | 0.004012 |
    | GET | http://192.168.121.243/volume/ | 0.004543 |
    +--------+------------------------------------------------+----------+

    The patch formats the "elapsed" time attribute into seconds and renames
    the column to "seconds" to make it more user friendly similar to OSC.
    If we didn't it would look like 0:00:00.003744

    Closes-Bug: #1960337
    Change-Id: Ia6b31794bf60a351007cc4476a76b9bcb76bf378

Changed in python-cinderclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 9.3.0

This issue was fixed in the openstack/python-cinderclient 9.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.