client calls bash-completion code from library calls

Bug #1817782 reported by Eric Harney on 2019-02-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Undecided
Eric Harney
python-manilaclient
Undecided
Unassigned

Bug Description

If you modify completion_cache() in base.py to fail with an error, for example adding:
    raise "asdf"
to the top of the method, unit tests such as
    cinderclient.tests.unit.v3.test_volumes.VolumesTest.test_create_volume

will fail. This test is not using the cinderclient shell, only the library. The completion code should not be called at all from library paths, only when using the CLI.

Reviewed: https://review.openstack.org/639422
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=a39805c6f45baf94c0d14da3ae775ee204a267ee
Submitter: Zuul
Branch: master

commit a39805c6f45baf94c0d14da3ae775ee204a267ee
Author: Eric Harney <email address hidden>
Date: Tue Feb 26 14:13:52 2019 -0500

    Tests: Don't write bash-completion cache files

    Mock out writing of bash-completion cache files
    during unit tests.

    Related-Bug: #1817782

    Change-Id: I944862c30fb4684dd034eba6953e9302d2d22439

Changed in python-cinderclient:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress
Eric Harney (eharney) wrote :
summary: - cinderclient appears to call bash-completion code from library calls
+ cinderclient calls bash-completion code from library calls
summary: - cinderclient calls bash-completion code from library calls
+ client calls bash-completion code from library calls
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers