Py3.7 test failures

[Corey Bryant]

python-glance unit tests have the following Py3.7 test failures: https://paste.ubuntu.com/p/4ggCBVGNrM/

To recreate, update tox.ini with a py37 target and run the tests on a machine that has python3.7 installed. Ubuntu Cosmic can be used as it has py3.7.

[Corey Bryant (corey.bryant)]

I'm having a hard time figuring out what's changed here. It seems most of the tests are failing due to an encoding change. This may be useful: https://docs.python.org/3/whatsnew/3.7.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602486
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=223d754f6162d87a305bcb2b041a5e73d5fae303
Submitter: Zuul
Branch: master

commit 223d754f6162d87a305bcb2b041a5e73d5fae303
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Sep 13 16:45:45 2018 -0600

    Fix encoding of query parameters

    IETF RFC 3986 classifies "~" as a reserved character [1],
    however until python3.7 [2], python's url parsing
    used to encode this character.

    urllib has seen a lot of churn in various python
    releases, and hence we were using a six wrapper
    to shield ourselves, however, this backwards-incompatible
    change in encoding norms forces us to deal with
    the problem at our end.

    Cinder's API accepts "~" in both, its encoded
    or un-encoded forms. So, let's stop encoding it
    within cinderclient, regardless of the version
    of python running it.

    Also fix an inconsitency around the use of the
    generic helper method in utils added in
    I3a3ae90cc6011d1aa0cc39db4329d9bc08801904
    (cinderclient/utils.py - build_query_param)
    to allow for False as a value in the query.

    [1] https://tools.ietf.org/html/rfc3986.html
    [2] https://docs.python.org/3/library/urllib.parse.html#url-quoting

    Change-Id: I89809694ac3e4081ce83fd4f788f9355d6772f59
    Closes-Bug: #1784728

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 4.1.0 release.