VolumeAttachmentManager methods aren't using cinderclient.api_versions.wraps decorator for microversion boundaries

[Matt Riedemann]

I noticed this in this review:

https://review.openstack.org/#/c/493263/2/cinderclient/v3/attachments.py

This code is already merged, but these methods should be using this decorator:

https://github.com/openstack/python-cinderclient/blob/f447b07490e36b513b70c557ae0a8327c2b109df/cinderclient/api_versions.py#L383

Like it's used here:

https://github.com/openstack/python-cinderclient/blob/f447b07490e36b513b70c557ae0a8327c2b109df/cinderclient/v3/volumes.py#L116

This means that if the client is making a request that doesn't fit that boundary, it will raise a VersionNotFoundForAPIMethod exception.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/502262

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/502262
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=da20fbf45bd094dae2b6a8869d0b5fd4b29b322b
Submitter: Jenkins
Branch: master

commit da20fbf45bd094dae2b6a8869d0b5fd4b29b322b
Author: j-griffith <email address hidden>
Date: Sat Sep 9 18:03:08 2017 +0000

    Add api_version_wraps to attachment-complete

    The attachment-complete method didn't include the version
    checking. This patch adds that and adds a couple of tests.

    Change-Id: I63dba6ee6d56bb63a79f3ad2ef3412ebd9c1ce07
    Closes-Bug: #1715732

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 3.3.0 release.