get_server_version does not handle older (non-v3) servers

[Matt Riedemann]

This method is checking for the v3 API:

https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/client.py#L88

But if this is talking to an older cinder server which doesn't have the v3 API then the for loop is going to complete and return None, which could lead to a NoneType here:

https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/client.py#L100

The for loop should probably have an else that raises ClientException so it defaults to return 2.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/469520

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/469520
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=7547e55bbebfeb4232968780cfed4d9a448594ae
Submitter: Jenkins
Branch: master

commit 7547e55bbebfeb4232968780cfed4d9a448594ae
Author: j-griffith <email address hidden>
Date: Wed May 31 08:44:07 2017 -0600

    cinderclient might not return version for V2 API

    The get_server_version call in cidnerclient/client.py relies on
    either finding v 3.x or encountering an exception to revert back
    to v 2.0. It's not clear that this call will always raise if
    a non V3 capable Cinder is called, so just to be safe make sure
    we return a 2.0 response if there's no V3 reported back.

    Change-Id: I3b5fb895cad4b85d5f4ea286fb33f7dd0929e691
    Closes-Bug: #1694729

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 3.1.0 release.