`retries` count is None if cinder client created with session

Bug #1684787 reported by Georgy Dyuldin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Georgy Dyuldin

Bug Description

If cinderclient constructing with passing keystone session object, `retries` property became to be None (instead of 0).

Example here: http://paste.openstack.org/show/607335/

If python version is 3 - this raises a TypeError on comparison here https://github.com/openstack/python-cinderclient/blob/master/cinderclient/client.py#L161
(TypeError: unorderable types: int() > NoneType())

affects: cinder → python-cinderclient
Changed in python-cinderclient:
assignee: nobody → Georgy Dyuldin (g-dyuldin)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/458455
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=85b56e1d88710453b3f2d5ceba1ad5a8715eb842
Submitter: Jenkins
Branch: master

commit 85b56e1d88710453b3f2d5ceba1ad5a8715eb842
Author: Georgy Dyuldin <email address hidden>
Date: Thu Apr 20 14:03:44 2017 +0300

    Fix client `retries` default value.

    In case of constructing Client with session without specifying `retries`
    value, `cinderclient.client.Client.retries` value become to None,
    instead of 0. This raises TypeError on python 3 during comparison
    `attempts > self.retries` on
    `cinderclient.client.SessionClient._cs_request`

    Closes-Bug: #1684787
    Change-Id: If1ac36acb0d1c92e9779e3e8995606c9b34f2cde

Changed in python-cinderclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 2.1.0

This issue was fixed in the openstack/python-cinderclient 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.