useless 'u' in the return info of "cinder get-capabilities"

Bug #1680444 reported by aohuanxuan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Abijitha Nadagouda

Bug Description

$ cinder get-capabilities ubuntu
+---------------------+-----------------------------------------------+
| Volume stats | Value |
+---------------------+-----------------------------------------------+
| description | None |
| display_name | None |
| driver_version | 3.0.0 |
| namespace | OS::Storage::Capabilities::ubuntu@lvmdriver-1 |
| pool_name | None |
| replication_targets | [] |
| storage_protocol | iSCSI |
| vendor_name | Open Source |
| visibility | None |
| volume_backend_name | lvmdriver-1 |
+---------------------+-----------------------------------------------+
+---------------------+---------------------------------------------------------------------------------------------------+
| Backend properties | Value |
+---------------------+---------------------------------------------------------------------------------------------------+
| compression | {u'type': u'boolean', u'description': u'Enables compression.', u'title': u'Compression'} |
| qos | {'type': 'boolean', 'description': 'Enables QoS.', 'title': 'QoS'} |
| replication_enabled | {u'type': u'boolean', u'description': u'Enables replication.', u'title': u'Replication'} |
| thin_provisioning | {u'type': u'boolean', u'description': u'Sets thin provisioning.', u'title': u'Thin Provisioning'} |
+---------------------+---------------------------------------------------------------------------------------------------+

We can see there are a lot of useless "u" in the output

aohuanxuan (huanxuan-ao)
Changed in python-cinderclient:
assignee: nobody → aohuanxuan (huanxuan-ao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/454159

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Bug Assignee Expired

Unassigning due to no activity for > 6 months.

Changed in python-cinderclient:
assignee: aohuanxuan (huanxuan-ao) → nobody
status: In Progress → Triaged
Changed in python-cinderclient:
status: Triaged → In Progress
assignee: nobody → Abijitha Nadagouda (abijithanadagouda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/535486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/454159
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=c3a22519bcd91db227146a982bfb281092428f6c
Submitter: Zuul
Branch: master

commit c3a22519bcd91db227146a982bfb281092428f6c
Author: Abijitha Nadagouda <email address hidden>
Date: Thu Apr 6 05:30:09 2017 -0700

    Removes unicode 'u' response for "cinder get-capabilities"

    The output of "cinder get-capabilities" command returns
    unicoded response. But it would appear from the utils
    class that setting formatters will go through the
    capabilities dict and make sure all values are properly
    string formatted. Therefore added formatters to return
    string formatted response.

    Added formatters=sorted(prop.keys()) line instead of
    static values as suggested by the reviewer, to avoid
    tying server knowledge to the client and also any
    update on the server side would easily reflect here.

    Closes-bug: #1680444
    Change-Id: Ie38236db364d59ddab42cb925d0435777b0ffe86

Changed in python-cinderclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Abijitha Nadagouda (<email address hidden>) on branch: master
Review: https://review.openstack.org/535486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 3.5.0

This issue was fixed in the openstack/python-cinderclient 3.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.