cinder list --metadata query option was accidentally removed

[Mitsuhiro Tanino]

In the commit I90a2b713556e91db69270a03ef6b798e08f93f90, --metadata option of do_list() in v2/shell.py was unexpectedly removed and --image_metadata option was added instead of --metadata option.

This fix is wrong because --image_metadata option requires API version >= "3.4" and is not supported at API v2. On the other hands, --metadata option of do_list() is supported from API v1.

We should remove --image_metadata option and then add --metadata option to the do_list() again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427875

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/427875
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=9e0f7983c2792e0bbc031b22b31896ce2b81f9da
Submitter: Jenkins
Branch: master

commit 9e0f7983c2792e0bbc031b22b31896ce2b81f9da
Author: Mitsuhiro Tanino <email address hidden>
Date: Wed Feb 1 12:41:32 2017 -0500

    Add --metadata option to API v2 cinder list command again

    In the commit I90a2b713556e91db69270a03ef6b798e08f93f90,
    --metadata option of do_list() in v2/shell.py was
    unexpectedly removed and --image_metadata option was
    added instead of --metadata option.

    This is wrong fix because --image_metadata option
    requires API version >= "3.4" and is not supported at
    API v2. On the other hands, --metadata option of
    do_list() is supported from API v1.

    We should remove --image_metadata option and then add
    --metadata option to do_list() again.

    Also comment on API v3 cinder list --metadata should
    be fixed because this doesn't require API >=3.4.

    Co-Authored-By: Masaki Kimura <email address hidden>

    Change-Id: Ic7d5cfa2acb47fbf73776e034d958ad8fb9119a8
    Closes-Bug: #1661045

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 2.0.0 release.