all volume v1 commands broken

[Rui Chen]

stack@szxbzci0004 ~/python-cinderclient (master) $ openstack --os-volume-api-version 1
WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils
(openstack) volume list
'NoneType' object has no attribute 'debug'
(openstack) snapshot list
'NoneType' object has no attribute 'debug'
(openstack) backup list
This command has been deprecated. Please use "volume backup list" instead.
'NoneType' object has no attribute 'debug'
(openstack)

[Rui Chen (kiwik-chenrui)]

self.logger can't be inited correctly in cinderclient class, add python-cinderclient into affected list.

NoneType exception is raised from here:

http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient/client.py#n91

[Sean McGinnis (sean-mcginnis)]

Should be self._logger instead of self.logger here:

http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient/client.py#n120

[Steve Martinelli (stevemar)]

I think this is a no-op for OSC, but i'll keep it as new for now until we test it out

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/359563

[Rui Chen (kiwik-chenrui)]

It's weird, why can't osc functional test catch the bug? volume v1 had been covered in it.

[Rui Chen (kiwik-chenrui)]

Looks like that I use the latest version (master > 1.8.0) of cinderclient, osc functional tests build the virtual env with cinderclient release version (1.8.0), the bug just exist in master, not 1.8.0.

Agree with Steve, the volume v1 commands had been covered by osc functional tests, so we don't need to fix it in osc side.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359563
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=639831b0961c76a8bfbed1fe1f21323159fb4d91
Submitter: Jenkins
Branch: master

commit 639831b0961c76a8bfbed1fe1f21323159fb4d91
Author: Rui Chen <email address hidden>
Date: Wed Aug 24 11:09:42 2016 +0800

    Fix NoneType error for cinderclient v1

    Request-id log is recorded in SessionClient.request() method,
    but None is used as logger, that causes all the v1 commands
    to be broken. This patch fixes the issue and updates the related
    unit tests.

    Change-Id: I46b973f2baca8d7402a39e0d15dbd8da38f4e590
    Closes-Bug: #1616070

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[Steve Martinelli (stevemar)]

This doesn't seem to be an issue any longer for OSC:

$ export OS_VOLUME_API_VERSION=1

$ env | grep OS
OS_PROJECT_NAME=admin
OS_IDENTITY_API_VERSION=2.0
OS_PASSWORD=openstack
OS_AUTH_URL=http://172.16.240.200:5000/v2.0
OS_USERNAME=admin
OS_TENANT_NAME=admin
OS_VOLUME_API_VERSION=1

$ openstack volume type create vt2
+---------------------------------+--------------------------------------+
| Field | Value |
+---------------------------------+--------------------------------------+
| description | None |
| id | fe7a1a29-56f8-4b3d-95d2-cad1bef9b0aa |
| is_public | True |
| name | vt2 |
| os-volume-type-access:is_public | True |
+---------------------------------+--------------------------------------+

stevemar@ubuntu:/opt/stack/python-openstackclient$ pip freeze | grep client
mysqlclient==1.3.7
ndg-httpsclient==0.4.0
oauth2client==3.0.0
os-client-config==1.21.1
python-barbicanclient==4.0.1
python-cinderclient==1.9.0
python-glanceclient==2.5.0
python-ironicclient==1.7.0
python-keystoneclient==3.5.0
python-neutronclient==5.1.0
python-novaclient==6.0.0
python-openstackclient==3.2.0
python-swiftclient==3.0.0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.