microversion 3.0's upload-to-image should not support “--visibility" and "--protected"

Bug #1589040 reported by Cao ShuFeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Cao ShuFeng

Bug Description

when "--os-volume-api-version 3.0" is passed to "cinder upload-to-image" command, cinderclient should not access cinder-api with argument "visibility" and "protected", but currently it does pass these two arguments in request url.

http://paste.openstack.org/show/497962/

This is bug is caused by another bug:

https://bugs.launchpad.net/python-cinderclient/+bug/1573414

Cao ShuFeng (caosf-fnst)
Changed in python-cinderclient:
assignee: nobody → Cao ShuFeng (caosf-fnst)
description: updated
Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/336767

Changed in python-cinderclient:
assignee: Cao ShuFeng (caosf-fnst) → Alex Meade (alex-meade)
Changed in python-cinderclient:
assignee: Alex Meade (alex-meade) → Cao ShuFeng (caosf-fnst)
Changed in python-cinderclient:
assignee: Cao ShuFeng (caosf-fnst) → Nate Potter (ntpttr)
Changed in python-cinderclient:
assignee: Nate Potter (ntpttr) → Cao ShuFeng (caosf-fnst)
Changed in python-cinderclient:
assignee: Cao ShuFeng (caosf-fnst) → Nate Potter (ntpttr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Cao ShuFeng (<email address hidden>) on branch: master
Review: https://review.openstack.org/336767
Reason: This is done here:
https://review.openstack.org/#/c/309283/

Changed in python-cinderclient:
assignee: Nate Potter (ntpttr) → Cao ShuFeng (caosf-fnst)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/309283
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=09a76374c38e217f29520be5dd898993f2fba37f
Submitter: Jenkins
Branch: master

commit 09a76374c38e217f29520be5dd898993f2fba37f
Author: Cao ShuFeng <email address hidden>
Date: Fri Apr 22 14:46:23 2016 +0800

    Fix useless api_version of Manager class

    Manager's api_version property is used by api_version.wraps. It
    should not be an "empty" class and the real api_version can be
    read from Client class.

    The 3.0 version's upload-to-image doesn't work as excepted because
    of this useless api_version of VolumeManager class. This patch also
    fix it and update some unit tests for it, because the changes are
    co-dependent on one another.

    Co-Authored-By: Nate Potter <email address hidden>

    Change-Id: I398cbd02b61f30918a427291d1d3ae00435e0f4c
    Closes-Bug: #1573414
    Closes-Bug: #1589040

Changed in python-cinderclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 1.9.0

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.