some __repr__ methods raise exception

Bug #1585024 reported by xiexs on 2016-05-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Undecided
Unassigned

Bug Description

Some __repr__ methods will raise the following exception:
"AttributeError: 'xxxx'

The reason for this issue is that an undefined attribute has been refered in the __repr__ method.

Changed in python-cinderclient:
assignee: nobody → xiexs (xiexs)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/320230

Reviewed: https://review.openstack.org/319931
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=906c9986a7e85b0029f4effd6ae3e3f5ca8fbfae
Submitter: Jenkins
Branch: master

commit 906c9986a7e85b0029f4effd6ae3e3f5ca8fbfae
Author: xiexs <email address hidden>
Date: Mon May 23 08:28:14 2016 -0400

    Make __repr__ print encryption_id for VolumeEncryptionType class

    The self.name attribute is undefined in the VolumeEncryptionType
    class. Instead we should print the self.encryption_id attribute
    in the __repr__().

    Change-Id: Ic11b45069145bbae078c8175928c5dd869bd8cb8
    Partial-Bug: #1585024

Reviewed: https://review.openstack.org/320223
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=0bf56a0a54524dfcda67727ca1c64e57bfaf0bc6
Submitter: Jenkins
Branch: master

commit 0bf56a0a54524dfcda67727ca1c64e57bfaf0bc6
Author: xiexs <email address hidden>
Date: Tue May 24 01:28:14 2016 -0400

    Fix Capabilities.__repr__ to remove the undefined attribute

    The self.name is undefined in the Capabilities class.
    And also there is no need any unique information to
    identify this object, so we just remove it directly.

    Change-Id: I0b821345c0d4c9a4636b9d097b9a66ba59768092
    Partial-Bug: #1585024

Reviewed: https://review.openstack.org/320230
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=f0f8e6b5ab3b3602e54f81d15af6c08e3c710545
Submitter: Jenkins
Branch: master

commit f0f8e6b5ab3b3602e54f81d15af6c08e3c710545
Author: xiexs <email address hidden>
Date: Sat Jun 25 11:43:32 2016 -0400

    Fix Service.__repr__ to remove the undefined attribute

    The self.name is undefined in the Service class.
    And also there is no need any unique information to
    identify this object, so we just remove it directly.

    Change-Id: I3ce8663f830357855f2155e080393ea97f8f80ba
    Partial-Bug: #1585024

Sean McGinnis (sean-mcginnis) wrote :

Are there any more known instances of this we need to fix, or do the three patches address this and we can close this bug?

Unassigning due to no activity for > 6 months.

Changed in python-cinderclient:
assignee: xiexs (xiexs) → nobody
status: In Progress → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers