Make dict.keys() PY3 compatible

[xiexs]

In PY3, dict.keys() will return a view of list but not a list anymore, i.e.
$ python3.4
Python 3.4.3 (default, Mar 31 2016, 20:42:37)
>>> body={"11":"22"}
>>> body[body.keys()[0]]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'dict_keys' object does not support indexing

so for py3 compatible we should change it as follows:
>>> body[list(body.keys())[0]]
'22'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293388
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=219c334f0169fe485b05bb9e5ae99edd9685dfb1
Submitter: Jenkins
Branch: master

commit 219c334f0169fe485b05bb9e5ae99edd9685dfb1
Author: xiexs <email address hidden>
Date: Thu May 19 00:11:50 2016 -0400

    Make dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Change-Id: Ia6c0783ca8c8514a06defbeed0fa9ef24bbd9d4a
    Closes-Bug: #1583419

[Dinesh Bhor (dinesh-bhor)]

This issue is also present in python-troveclient.

https://github.com/openstack/python-troveclient/blob/master/troveclient/compat/exceptions.py#L166

[Dinesh Bhor (dinesh-bhor)]

Hi All,

This issue is also present in nova, cinder and python-manilaclient as well.

nova:
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/volumes.py#L71

cinder:
https://github.com/openstack/cinder/blob/master/cinder/backup/manager.py#L128

python-manilaclient:
https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/functional/test_shares_metadata.py#L139

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332099

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332101

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332593

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332661

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332593
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d
Submitter: Jenkins
Branch: master

commit 0b7c9f4f991fbdc1c5cc2f3f50dc24ee9a6ac59d
Author: yuyafei <email address hidden>
Date: Wed Jun 22 10:27:49 2016 +0800

    Make dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3, as dict.keys()
    doesn't return a list any more in PY3 but a view of list.

    Change-Id: I0a7a1fbbcd8394dbe100a50b23126897c2da3865
    Closes-Bug: #1583419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332081
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=dabe872cbcfd815c63fe5816858923b1e908eefe
Submitter: Jenkins
Branch: master

commit dabe872cbcfd815c63fe5816858923b1e908eefe
Author: dineshbhor <email address hidden>
Date: Tue Jun 21 16:15:41 2016 +0530

    Make dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Change-Id: Id9c7d3725c01bd0a193d8fc6705443efe9c25c34
    Partially implements: blueprint trove-python3
    Closes-Bug: #1583419

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/333169

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332099
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c25998ee429ca796e8b15f3800a775ccdc5ab029
Submitter: Jenkins
Branch: master

commit c25998ee429ca796e8b15f3800a775ccdc5ab029
Author: dineshbhor <email address hidden>
Date: Tue Jun 21 14:49:34 2016 +0530

    Make dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Closes-Bug: #1583419
    Change-Id: I8e05cf4d68568f9446f752418277764c2ce94ff4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332101
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=1e9ba407837648d428e5ac0b4cba46dea7f46e39
Submitter: Jenkins
Branch: master

commit 1e9ba407837648d428e5ac0b4cba46dea7f46e39
Author: dineshbhor <email address hidden>
Date: Tue Jun 21 17:00:13 2016 +0530

    Make dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Change-Id: I5d8dead560acd897213e785d6eb0bc75a584af1b
    Closes-Bug: #1583419

[OpenStack Infra (hudson-openstack)]

Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https://review.openstack.org/333169

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-troveclient 2.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337440
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=df7c0dad5ba45bc5122ebc2fe2aa3f4330d57a55
Submitter: Jenkins
Branch: master

commit df7c0dad5ba45bc5122ebc2fe2aa3f4330d57a55
Author: qinchunhua <email address hidden>
Date: Tue Jul 5 02:01:20 2016 -0400

    Fix dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Change-Id: I99514d57cb21bf65a59eb36b556248b9494246c7
    Closes-Bug: #1583419

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/341946

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-manilaclient 1.10.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332661
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=31ed226a67ff6b2320f605ce436658312cf0c701
Submitter: Jenkins
Branch: master

commit 31ed226a67ff6b2320f605ce436658312cf0c701
Author: Bin Zhou <email address hidden>
Date: Wed Jun 22 16:35:12 2016 +0800

    Refactor usage of dict.values()[0]

    The dict.values()[0] will raise a TypeError in PY3, as dict.values()
    doesn't return a list any more in PY3 but a view of list. This patch
    is to fix this bug by refactoring the relevant code.

    Change-Id: I4362a22322807eda8d795d68395445d53ab60ad4
    Closes-Bug: #1583419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/341946
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=cd60336e209e8900d28e06c167977ba21a07038c
Submitter: Jenkins
Branch: master

commit cd60336e209e8900d28e06c167977ba21a07038c
Author: weiweigu <email address hidden>
Date: Thu Jul 14 13:45:47 2016 +0800

    Fix dict.keys() PY3 compatible

    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.

    Change-Id: If15a153c9db9b654e761f8ad50d5d66a427efa4e
    Closes-Bug: #1583419

[Akihiro Motoki (amotoki)]

networking-l2gw patch is https://review.openstack.org/343509.
It seems the patch has been merged before networking-l2gw was added to the affected project :-(

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tacker 0.4.0 release.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/watcher 0.29.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.