Clean up warnings about keystoneclient.adapter.Adapter

[Jay Pipes]

Nova test runs output a bunch of warnings about keystoneclient.adapter.Adapter:

Captured stderr:
~~~~~~~~~~~~~~~~
    /home/jaypipes/repos/nova/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/adapter.py:57: DeprecationWarning: keystoneclient.adapter.Adapter is deprecated as of the 2.1.0 release in favor of keystoneauth1.adapter.Adapter. It will be removed in future releases.
      'removed in future releases.', DeprecationWarning)

[Markus Zoeller (markus_z) (mzoeller)]

@Rahul: Are you still working on this? Do you like to have assistance?

[Markus Zoeller (markus_z) (mzoeller)]

The warnings with Newton master, commit b9d757b: http://paste.openstack.org/show/493964/

[Rahul U Nair (rahulunair)]

@Markus, I am no longer working on this bug., un-assigning myself.

[Markus Zoeller (markus_z) (mzoeller)]

These warnings get triggered by the python-cinderlient which uses deprecated keystoneclient code. Nova cannot prevent that. The Cinder folks should look into that.

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "nova/tests/unit/test_cinder.py", line 238, in test_volume_without_attachment
        volume = self.api.get(self.context, '5678')
      File "nova/volume/cinder.py", line 232, in wrapper
        res = method(self, ctx, *args, **kwargs)
      File "nova/volume/cinder.py", line 255, in wrapper
        res = method(self, ctx, volume_id, *args, **kwargs)
      File "nova/volume/cinder.py", line 301, in get
        item = cinderclient(context).volumes.get(volume_id)
      File "nova/volume/cinder.py", line 147, in cinderclient
        **service_parameters)
      File "/home/mzoeller/git/nova/.tox/py27/lib/python2.7/site-packages/cinderclient/client.py", line 634, in Client
        return client_class(*args, **kwargs)
      File "/home/mzoeller/git/nova/.tox/py27/lib/python2.7/site-packages/cinderclient/v2/client.py", line 117, in __init__
        **kwargs)
      File "/home/mzoeller/git/nova/.tox/py27/lib/python2.7/site-packages/cinderclient/client.py", line 551, in _construct_http_client
        **kwargs)
      File "/home/mzoeller/git/nova/.tox/py27/lib/python2.7/site-packages/positional/__init__.py", line 101, in inner
        return wrapped(*args, **kwargs)
      File "/home/mzoeller/git/nova/.tox/py27/lib/python2.7/site-packages/keystoneclient/adapter.py", line 54, in __init__
        raise Exception("mzoeller: baem!!")
    Exception: mzoeller: baem!!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/312357

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/312357
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Fixed with https://review.openstack.org/#/c/290464/