cinderclient logs sensitive info in http requests

Bug #1516689 reported by Anna Sortland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
High
Jose Porrua
python-cinderclient
Fix Released
High
Jose Porrua

Bug Description

cinderclient logs sensitive info in headers when logging http requests in debug mode.

This happens in a couple of places:
cinderclient/openstack/common/apiclient/client.py:_http_log_req()
cinderclient/client.py:http_log_req()

cinderclient should hash sensitive info in headers such as 'X-Auth-Token' and 'X-Subject-Token'.
For examples, see keystoneclient (https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/openstack/common/apiclient/client.py#L105), glanceclient, or ceilometerclient.

Changed in cinder:
assignee: nobody → Jose Porrua (jose-porrua)
Alex Meade (alex-meade)
Changed in cinder:
status: New → In Progress
Changed in python-cinderclient:
status: New → In Progress
Changed in python-cinderclient:
assignee: nobody → Jose Porrua (jose-porrua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275755

Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
Jay Bryant (jsbryant)
Changed in python-cinderclient:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/275755
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=5efb5964f7eedf002e9535bf202b5da9ac5e200f
Submitter: Jenkins
Branch: master

commit 5efb5964f7eedf002e9535bf202b5da9ac5e200f
Author: Jose Porrua <email address hidden>
Date: Fri Jan 15 15:07:53 2016 -0500

    Avoid logging sensitive info in http requests.

    This patch follows the same approach as other OpenStack python
    clients, by adding a safe header method to hash sensitive information.

    Change-Id: I980ea7411b1e7f6d47d0a75d58de87b0f944d0d9
    Closes-bug: #1516689

Changed in python-cinderclient:
status: In Progress → Fix Released
Changed in cinder:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 1.6.0

This issue was fixed in the openstack/python-cinderclient 1.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.