Enhance user input check in 'cinder type-key'

[Peter Wang]

When I tried to set extra specs for a volume type i used following:

       cinder type-key cgtype set test= aa

above format is not the allowed format(I typed an SPACE before 'aa'):

stack@ubuntu14:~/devstack$ cinder type-key
usage: cinder type-key <vtype> <action> <key=value> [<key=value> ...]

while cinderclient did not do format check and produced unexpected result:

stack@ubuntu14:~/devstack$ cinder extra-specs-list
+--------------------------------------+-------------+------------------------------------------+
| ID | Name | extra_specs |
+--------------------------------------+-------------+------------------------------------------+
| 9536cd2f-d336-4b5c-a572-b5a24c98a6b0 | cgtype | {u'test': u'', u'aa': None} |
+--------------------------------------+-------------+------------------------------------------+

what i want is {'test': 'aa'}

This behavior would cause confusion when user uses this type to create volume.

Thanks
Peter

[Syed Ahsan Shamim Zaidi (ahsanmohsin04)]

Hi Peter,

It is an error as you have said since there should not be any space, it should be test=aa.

However, did you tried cinder type-key cgtype set ['test'='aa'].
I dont think one can get the output other way, rather then u'xxx'

Let me know if it works.

[Peter Wang (peter.wang)]

actually, the space before aa is typo, but I did not get notified even if
 my format was wrong. finally, I got unexpected result as I mentioned.

my point is to do format check before writing to the database~~

thanks
peter

[Peter Wang (peter.wang)]

Is there any update for this bug?

[Sean McGinnis (sean-mcginnis)]

There really isn't much that can be done about this since we don't know what your intention is when parsing the command input. As you saw, that input was valid. Just not what you had wanted to do.