search_opts parameter of volumes_types.list() is not used

Bug #1508102 reported by Andrey Pavlov
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Wishlist
Yuriy Nesenenko
python-cinderclient
Invalid
Wishlist
Yuriy Nesenenko

Bug Description

volume_types.list() method has a search_opts parameter, which is not used

summary: - search_opts parameter of volumes_type.list() is not used
+ search_opts parameter of volumes_types.list() is not used
Changed in python-cinderclient:
status: New → Confirmed
chenying (ying-chen)
Changed in python-cinderclient:
assignee: nobody → chenying (ying-chen)
chenying (ying-chen)
Changed in python-cinderclient:
assignee: chenying (ying-chen) → nobody
Changed in python-cinderclient:
assignee: nobody → Jude Augustine Job (judeaugustine-j)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248350

Changed in python-cinderclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/248350
Reason: Abandoning per comments. If there is some reason to continue with this, feel free to unabandon and address the concerns.

Changed in python-cinderclient:
assignee: Jude Augustine Job (judeaugustine-j) → nobody
Revision history for this message
Sheel Rana (ranasheel2000) wrote :

I am marking this as incomplete.

Please provide some more details about why search_opts parameter of volumes_types.list() should not be kept in code.

Changed in python-cinderclient:
status: In Progress → Incomplete
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

Sheel, who said that it should be removed? We have this parameter, but it should USED, so we need to invent an way how to pass that to Cinder API if such way exists.

Changed in python-cinderclient:
status: Incomplete → New
Changed in python-cinderclient:
assignee: nobody → gundarapu kalyan reddy (gundarapu-reddy)
Changed in python-cinderclient:
status: New → Confirmed
Changed in cinder:
assignee: nobody → gundarapu kalyan reddy (gundarapu-reddy)
status: New → Confirmed
Revision history for this message
Sheel Rana (ranasheel2000) wrote :

>Sheel, who said that it should be removed?
vitaly Gridnev, In proposed patchset this was suggested which seemed wrong to me.
Refer patch set extracts
def list(self, search_opts=None, is_public=None): -> def list(self, is_public=None):

That is why the query came, why to remove this parameter, better to keep this and update the way it should be used.
I think we are same page.

Changed in python-cinderclient:
status: Confirmed → In Progress
Changed in cinder:
assignee: gundarapu kalyan reddy (gundarapu-reddy) → Yuriy Nesenenko (ynesenenko)
Changed in python-cinderclient:
assignee: gundarapu kalyan reddy (gundarapu-reddy) → Yuriy Nesenenko (ynesenenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cinder (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/344172

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/344256

Changed in cinder:
status: Confirmed → In Progress
Changed in cinder:
importance: Undecided → Wishlist
Changed in python-cinderclient:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Yuriy Nesenenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/344172

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Yuriy Nesenenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/344256
Reason: search_opts parameter is used at deleting volume-type by name

Changed in python-cinderclient:
status: In Progress → Invalid
Changed in cinder:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.