cinderclient ignores CINDER_SERVICE_NAME

[Derrick Wippler]

When CINDER_SERVICE_NAME is set in the environment cinderclient ignores the service name when choosing an endpoint. The Code reveals cinderclient is not passing self.service_name to self.service_catalog.url_for() near line 334 in client.py

I'll submit a patch for review shortly.

[Cory Stone (corystone)]

This was introduced when switching to the keystoneclient service_catalog code. For some reason they stopped passing in all the necessary arguments.

See commit: 1b0ea876 which was trying to fix bug #1263876

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214802
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=e8274fa57df3a833f8e46be2e9a6feff366e4b5c
Submitter: Jenkins
Branch: master

commit e8274fa57df3a833f8e46be2e9a6feff366e4b5c
Author: Derrick J. Wippler <email address hidden>
Date: Wed Aug 19 15:48:27 2015 -0500

    No longer ignores CINDER_SERVICE_NAME

    Cinderclient now utilizes the CINDER_SERVICE_NAME when deciding what
    endpoint to choose.

    Closes-Bug: #1486256
    Change-Id: I494a34afe5799e7832b1359b9c24c31ead68b6d1
    UpgradeImpact: Existing configurations may select a different endpoint
    after this patch.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in openstack/python-cinderclient 1.5.0 release.